E107: download plugin - problem with restricted to members

[Jimmi08]

I use download plugin on two different sites. Some of them can be downloaded just by members.

Download is visible, just request can be downloaded by member. But when they tried it, they get message about You have been prevented from downloading this file; you have exceeded your download quota
not that they haven't permission.

On second site quest see this:

Limits are set this way (default)

Thanks

[Jimmi08]

Example on the same site:

first download

second download

[tgtje]

Just testing the hp site > last download (as example) (guest) > action=error&id=4 > chyba 4 ( General error # ID is triggered)..
Are the files present and how is chmod and/or language ?
(can not replicate issue myself)

[Jimmi08]

Hi, files are there, member can download them.
You can try it here:
http://www.e107.sk/download/5/links-page-plugin-2-3-1
language is English to avoid language issue.
But it's true that on this site I have a lot of problems with this plugin (in admin area too). Second site is on different server and except this issue download plugin works fine. I will update everything and see,

[Jimmi08]

ok, site is updated, problem with download plugin is there too. Only change I made was to add this to htaccess because setting this in site prefs didn't work.

RewriteCond %{HTTP_HOST} !^www\.
RewriteRule ^(.*)$ http://www.%{HTTP_HOST}/$1 [R=301,L]

I can't debug this because if I use Firefox e107 debuger, my admin is empty. Not on localhost, just on production site.

Console is empty. No error.

I can't edit download now too. Empty screen. Only on production site. My php version was 5.4.37, so I changed it to 5.5 (to be on the same version as localhost) and debugger started to work and edit download is possible too.

The reason for that happened just now not before was that on my hosting I had 5.5 for e107.sk, but for *.e107.sk there was5.4 (and using www caused that problem) . So there is problem with download plugin and php 5.4 version.

I will try to add more info to issue above.

[Jimmi08]

I was able to reproduce this error on localhost. Now I just confirm that if file is not present, message is correct

[Jimmi08]

I have it.
First part of this test is always true in my case

But in old version there were

• there is mising "1" in url, but test is
  

so that is reason why I get generic error.

[tgtje]

Hmm error 5 on sk...
Just curious .. did/do you use sef troughout?(or external/mirrored)
Example of what i mean...2 links; 1 yours, 1 mine: both represent the Get it (download)

e107.sk/download/get/5/links-page-plugin-2-3-1
domain/e107_plugins/download/request.php?1
and
th.../e107World/css/bootstrap.min.css.map is called somewhere but not found..

[Jimmi08]

I found the reason, there is no code for error in request.php file. Do you see this:

if my id is 5, my error will be 5 and error message is only for 1 or 2. So with download ID < 3 I've got message (wrong, but it's there) otherwise it's just error.

no SEF-URL

with SEF-url:

[Jimmi08]

@CaMer0n Could you just look if I am right or not? In request.php there is no code for error (just action and download ID) and it uses download id as code error. It just happens where download is visible for all but file is restricted to download for members. Thanks

[CaMer0n]

@Jimmi08 Is this still an issue?

[Jimmi08]

@CaMer0n I updated to latest github, but problem is still there

[CaMer0n]

Thanks @Jimmi08. Could you please send a pull-request of your proposed fix so I can review it?

[Jimmi08]

@CaMer0n on I have no idea how to fix this.

[cameron]

Neither do I! ;)

[Jimmi08]

@CaMer0n

@cameron I am sorry. I know about this problem, I am very carefully about this, but I was on mobile phone and there were capitals so... They really should do something with checking nicks with case-sensitive.

[fizi]

I confirm the error.

[rica-carv]

Workaround. Replace request.php line 252 with this:
$goUrl = e107::getUrl()->create('download/index')."?action=error&id=1";

Not making a pull request because i can't simply figure out why is the variable $id is returned instead of 1, so that the correct message is rendered...

[CaMer0n]

@Jimmi08 @fizi @tgtje Would you mind please re-testing with the patch?

[fizi]

On English - ok, on Hungarian the problem same.

[tgtje]

Did replace the file lines. for me NO actual change. I will need to investigate deeper as it still does point me to something doing something to the url's (sef vs full paths).

As for fizi's site : i can confirm the error lines are changed to language eg displayed text. Clicking here and there (no point in describing which where, 1 example : lang switch) it will lead eventually to also url misbehaviour > ends in 404.. Very puzzled at the moment....

[Moc]

Make sure the caches are cleared when debugging this issue :)

[Jimmi08]

Latest github.
For me problem is solved (problem in this issue):

Thanks to all.

[fizi]

Perfect in both languages! Thanks!