Dynmap: PHP 7 Compatibility?

Created on 10 Jan 2017  路  7Comments  路  Source: webbukkit/dynmap

Is dynmap PHP7 compatible? I ran a checker before upgrading and got a couple of those here:

File: /bukkit/plugins/dynmap/web/standalone/MySQL_register.php

Line 69: Removed function "split" called
split('=', rtrim($lines[$i]));

File: /bukkit/plugins/dynmap/web/standalone/login.php

Line 50: Removed function "split" called
split('=', rtrim($lines[$i]));

File: /bukkit/plugins/dynmap/web/standalone/register.php

Line 60: Removed function "split" called
split('=', rtrim($lines[$i]));

File: /bukkit/plugins/dynmap/web/standalone/MySQL_login.php

Line 51: Removed function "split" called
split('=', rtrim($lines[$i]));

Does someone have experience running Dynmap on PHP7?

Most helpful comment

@SimonOrJ PR looks good - thanks @SimonOrJ!

All 7 comments

As it stands now, no.

I've made a PR to fix this, but webbukkit team hasn't been on it yet.

https://github.com/webbukkit/DynmapCore/pull/76

Just replace those "split" with "explode"

@SimonOrJ does only that make dynmap compatible with php7.0?

The usage of split() in the four files is the only thing that breaks php7.0 compatibility as far as I've seen.

@SimonOrJ That is good news, thank for providing that info.

https://github.com/webbukkit/DynmapCore/pull/76 really needs to be pulled into master soon. The default repository for latest version of Ubuntu no longer contains php5.

@mikeprimm

@SimonOrJ PR looks good - thanks @SimonOrJ!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Military-Doctor picture Military-Doctor  路  3Comments

MissFox0810 picture MissFox0810  路  3Comments

TomberWolf picture TomberWolf  路  4Comments

fuwwy picture fuwwy  路  3Comments

XxTWMLxX picture XxTWMLxX  路  7Comments