Dvc: Use path_isin instead of startswith to compare filepaths
The PR #2798 introduced dvc.utils.fs.path_isin that can be used to compare child paths and parent paths and therefore, raw string compare with startswith can be replaced with this new function.
Refactor usage of startswith for paths with path_isin.
skshetry
All 3 comments
@efiop, can I take this? If yes, please assign me. :)
skshetry
on 20 Nov 2019
🚀1
@skshetry Sure, go ahead 馃檪
efiop
on 21 Nov 2019
Looked through the codebase. The difference between path_isin and startswith is that, the former will be false if they are same path. The latter is being used here in the cases of where the path are same as well. Found 5/6 uses of startswith only.
skshetry
on 21 Nov 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings
Related issues
analystanand
路
3Comments
shcheklein
路
3Comments
dnabanita7
路
3Comments
anotherbugmaster
路
3Comments
dmpetrov
路
3Comments
Most helpful comment
Looked through the codebase. The difference between
path_isinandstartswithis that, the former will be false if they are same path. The latter is being used here in the cases of where the path are same as well. Found 5/6 uses ofstartswithonly.