Dvc: remote: a bug in _collect_used_dir_cache() for non local

Created on 18 Oct 2019  路  3Comments  路  Source: iterative/dvc

On master branch.

These lines
https://github.com/iterative/dvc/blob/638aaa254ea475947545edd046116befe82040f1/dvc/output/base.py#L360-L366
try to pull dir listing to local cache, but later we try to open it on remote, with self.cache.open(...).

bug p2-medium

Most helpful comment

@dmpetrov yes, it doesn't lead to an error though, only makes unneeded download or status check if a dir listing is already downloaded.

All 3 comments

For the record: This is a leftover from the time when we didn't have Remote.open().

Guys, is it still relevant?

@dmpetrov yes, it doesn't lead to an error though, only makes unneeded download or status check if a dir listing is already downloaded.

Was this page helpful?
0 / 5 - 0 ratings