Dvc: config: `dvc config` doesn't throw an error when used outside of a dvc repository without --system or --global

[ghost]

DVC version: 0.52.1+1e9f1d
Python version: 3.7.3
Platform: Linux-5.2.1-arch1-1-ARCH-x86_64-with-arch
Binary: False
Filesystem type (workspace): ('xfs', '/dev/mapper/vg-root')

---

rm -rf .dvc
dvc remote modify something whatever yeah

Expected

ERROR: you are not inside of a dvc repository (checked up to mount point '/')

[efiop]

@mroutis Remotes can be defined in global or system configs. This is not a bug.

[efiop]

Ah, wait. So the .dvc is removed... So looks like running that command anywhere will create .dvc/config, right? Re-opening. Sorry for jumping on this one.

[ghost]

@efiop , running dvc remote modify on a directory which is not a DVC repository doesn't do anything at all. You are right, --system and --global shouldn't throw an error, but for --local and without any flag, it should.

[efiop]

Issue is relevant for dvc config in general, as dvc remote derives from it. Some explanation https://github.com/iterative/dvc/pull/3194#pullrequestreview-344982907 . Adjusting the naming...

[efiop]

Related https://github.com/iterative/dvc/issues/2234 , should be fixed by the redesign.

[efiop]

For the record, this might require full config refactor (and likely will), so please check back before tackling this one, just to make sure that we are on the same page.