Dvc.org: glossary: rewrite tooltip (desktop-view) using "Portals"?

[algomaster99]

React Portals is a good way to create elements which hover above the DOM. Currently, it is created using position: fixed and other relevant styles. I think implementing this will make it more polished.

[jorgeorpinel]

What are some example elements that are currently hovering above the DOM? Tooltips? What else? Thanks

[algomaster99]

@jorgeorpinel Tooltip but only for mobile view. I tried creating it for desktop too but there were some problems. Refer to PR.

[shcheklein]

@algomaster99 @iAdramelk so, should we just close this then?

[algomaster99]

To solve this issue, we will have to position the root element, modal in this case, absolutely w.r.t the text. I couldn't figure out to do so. @iAdramelk do you have any ideas for execution?

[algomaster99]

@shcheklein I will have to refer to their code find out how they have done it.
It is working fine though. This issue is opened just to adhere to the conventions. :sweat_smile:

[iAdramelk]

@shcheklein I think that we should leave the ticket open, but reduce it's priority. Solving it will require changing the basic layout first, without this changes I also not sure how to solve it right now.

[jorgeorpinel]

Per Aman and Alexey above, it seems this is not high priority. Assigned p2 but maybe doesn't even need a p?

[fabiosantoscode]

Maybe we could make the leap and use popper. It's really solid and should be easy to set up:

https://www.npmjs.com/package/react-popper

[shcheklein]

not sure it worth spending time on this, tbh. Polishing is definitely not a good primary goal.

[shcheklein]

I'm going to close this actually until we have some strong reasons.

[jorgeorpinel]

Great logo