Dvc.org: Indentation removed in bulleted list

Created on 20 May 2019  路  10Comments  路  Source: iterative/dvc.org

Commit a57596 removes indentation from bulleted list.

Issue

- Syntax highlighting in fenced code blocks should use the `usage` and `dvc`
custom languages:

Fix

- Syntax highlighting in fenced code blocks should use the `usage` and `dvc`
  custom languages:

This can be fixed by running npm run prettier-md.

bug doc-content good first issue priority-p1

Most helpful comment

I will submit pr for it. :D @algomaster99

All 10 comments

Will you please screenshot those particular blocks and give me a brief review of it!

@ryokugyu

Issue

Screenshot from 2019-05-20 19-55-14

After formatting

Screenshot from 2019-05-20 20-04-19

@ryokugyu @algomaster99 yep, that commit was too aggressive. Let's run prettier. We should check that it will indent code blocks under list items back (two spaces).

@shcheklein Yes, npm run prettier-md works. @ryokugyu Will you submit a PR? :smile:.

I will submit pr for it. :D @algomaster99

Hello! You may want to take a look at #363 as you work on this one. Thanks

@ryokugyu hey, any updates on this?

@jorgeorpinel does your last PR fixes that? This one should be done for the most part. Except some code block under list items - not a big issue I think.

Yes it was fixed in recent PRs including #378 e.g. https://github.com/iterative/dvc.org/pull/378/files#diff-ad6b7d6b56ae9694f56f7d353f1eb56aR38

Closing (:

@ryokugyu hey, any updates on this?

I didn't worked on it because of the issue of #363

Was this page helpful?
0 / 5 - 0 ratings