Dune: Missing newline after build

Created on 21 Aug 2020  路  4Comments  路  Source: ocaml/dune

Expected Behavior

Entering directory '...'
Done: 914/915 (jobs: 1)
13:45:36 user@mach$

Actual Behavior

Entering directory '...'
Done: 914/915 (jobs: 1)13:45:36 user@mach$

Reproduction

Any dune build foo.exe should do. It seems the problem was only introduced very recently.

Specifications

  • Version of dune: 2.7.0
  • Version of ocaml: 4.11.0
  • Operating system (distribution and version): Mac OS X 10.15.6
bug

Most helpful comment

I've made a PR that fixes this: https://github.com/ocaml/dune/pull/3767

All 4 comments

I think I bisected that to 5c133a06f8c5f252abe2b7a855834530fd57d5cb (#3607, @jeremiedimino), so I don't think I'll be able to debug this further :sweat_smile:

Another example, when building a workspace with multiple switches:

dune build --always-show-command-line --workspace=dune-workspace.test
Done: 12498/12503 (jobs: 1)dune runtest --workspace=dune-workspace.test
Done: 15893/15897 (jobs: 1)%

(the % is added by my zsh shell to mark the absence of newline at the end of the output)

I'll assign this to Jeremie since I'm also puzzled by this.

I've made a PR that fixes this: https://github.com/ocaml/dune/pull/3767

Was this page helpful?
0 / 5 - 0 ratings