Drone: server: nil pointer dereference when trying to access any page

[mvdan]

Full log from the server container:

2018/03/23 18:00:06 [Recovery] panic recovered:
GET /api/repos/___/builds HTTP/1.1
Host: ___
Accept: */*
Accept-Encoding: gzip, deflate, br
Accept-Language: ___
Cache-Control: no-cache
Connection: keep-alive
Cookie: user_sess=___
Dnt: 1
Pragma: no-cache
Referer: https://___
User-Agent: ___

runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:489 (0x430c7f)
/usr/local/go/src/runtime/panic.go:63 (0x42fb2e)
/usr/local/go/src/runtime/signal_unix.go:290 (0x445dcf)
/go/src/github.com/drone/drone/remote/github/github.go:209 (0xa35021)
/go/src/github.com/drone/drone/router/middleware/session/repo.go:97 (0x8826cd)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/router/middleware/session/repo.go:50 (0x881cf0)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/router/middleware/token/token.go:26 (0x8836c7)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/router/middleware/session/user.go:68 (0x882b82)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/router/middleware/store.go:15 (0x982cb7)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/contrib/ginrus/ginrus.go:26 (0x98310f)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/router/middleware/header/header.go:25 (0x87a700)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/router/middleware/header/header.go:17 (0x87a6a9)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/recovery.go:45 (0x87836a)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/context.go:97 (0x86a0da)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/gin.go:284 (0x86ff10)
/go/src/github.com/drone/drone/vendor/github.com/gin-gonic/gin/gin.go:265 (0x86f82b)
/usr/local/go/src/net/http/server.go:2568 (0x6cc7f2)
/usr/local/go/src/net/http/server.go:1825 (0x6c8992)
/usr/local/go/src/runtime/asm_amd64.s:2197 (0x45f881)

This is running both a server and agent 0.8.4 via the standard docker-compose on a single machine.

I've tried restarting both containers, syncing the repositories, accessing many pages, and logging out and back in, but nothing seems to un-break it. I've had a look at the lines in question and I don't see anything obvious.

We've had Drone running for weeks with no issues; no idea as to what might have caused this to start.

[bradrydzewski]

Please consider opening a support ticket with github. There was a regression within the last 60 minutes and their API response is missing the permission field which should always be present when making authenticated API calls. Drone cannot work without this field, so we need their engineering support to resolve. I have opened a support ticket with github, and hope to hear from them soon.

{
    "id": 16607898,
    "name": "drone",
    "full_name": "drone/drone",
    "permissions": { <<<<<<<<<<<<<< missing
      "admin": false,
      "push": false,
      "pull": true
    }
}

[mvdan]

Ah, I imagined this could be github being fucky, but their status page was green. How did they make such a big breaking change this easily?

Is there a ticket or a thread somewhere where I can follow this?

[bradrydzewski]

I created a ticket using https://github.com/contact but unfortunately it does not provide a public link that I can share.

I also tweeted them:
https://twitter.com/bradrydzewski/status/977250591909933056

[mvdan]

Awesome, thank you. They are the worst for breaking this on a friday :)

[bradrydzewski]

FYI github has confirmed the regression and is working on a fix :)

[bradrydzewski]

UPDATE: everything is operating normally https://status.github.com/messages#2018-03-23

closing this issue.