As part of #13832, should rework Jekyll styling into a source-controlled form that has no license ambiguity and enables due-diligence agency of modifying the website (e.g. will assume devs know how to look at W3C for HTML + CSS stuff, Jekyll docs).
Artifacts to reconcile:
#website channel with artifacts that need to be reconstructedInitial steps:
See #14657 for PR train
Per meeting, @IanTheEngineer and I will take this. I will spearhead, and then ask Ian for help / review.
FYI @jwnimmer-tri @ToffeeAlbina-TRI @ggould-tri @rpoyner-tri
@BetsyMcPhail Can you advise on which PR we should use for sample content to target styling against?
Internet's going slow; going to timebox to 30min today, trying out re-styling with #14488
Filed #14576
Can you advise on which PR we should use for sample content to target styling against?
To obtain some sample markdown files (i.e., some lorem ipsum) so as to have actual text to display, in #14488 you only have ~one file, getting_help.md.
If you want _many_ markdown files at once, the draft in #14479 has a whole bunch, and is probably a better starting place to snag a few. (You probably don't need them all.)
@BetsyMcPhail has the licenses are separated out, and everything fixed, but that may only exist locally now. You can reach out to her and she can push the latest version somewhere that is laid on a platter for you all to review.
Ooh, yes, that would be awesome!
Betsy, would be able to push what you have in terms of licensing?
She has literally everything, so all you are going to need to do is cherry-pick and review. The markdown she has should be an up-to-date sync with the rst modulo maybe a week. Should appear shortly.
The branch with all of my changes is available here .
Thanks! Just to check, can you tell me how you generated the base support files in f7866d7cdd?
The commit message states that some of them come from the web devs that made the redux, but it's unclear. Also, for licensing, it's unclear if this came from a template setup from Jekyll; is it possible to clarify that?
Also, for licensing, it's unclear if this came from a template setup from Jekyll; is it possible to clarify that?
Unlikely, but given the license of a tool, it does not imply anything about the license of the output, regardless.
BTW whether the web developers dropped a new file into a directory or edited such file or whether Betsy did, they are both work for hire for the same client, so the copyright and license of new files would be identical.
(unless the contract with the web developers specified otherwise, which would be very unusual)
Yes, it was all work for hire, so you're gist is correct -- TRI owns the copyright. The only question is whether anyone copied files from _elsewhere_ and dropped them into the folder. Anything created out of thin air is fine, anything downloaded from the internet needs a confirmation of our rights.
I think that is documented in any case that it could be reasonably inferred. Betsy will confirm.
Anything in the developers' work that was clearly third party code has either been removed or is part of its own commit with appropriate license and documented source.
In commit f7866d7:
Unlikely, but given the license of a tool, it does not imply anything about the license of the output, regardless.
True, but I would like to confirm (e.g. if the template generation produces a derivative of licensed template files, would be nice to know?)
You will need to ask the web developers, then. It is a lot of work for no consequence.
Trust but verify is the motto that I will go by. Verify will take place in a PR that I start, but leveraging Betsy's work, where we will go through line-by-line to identify any possible licensing issues.
The PRs will most likely break up f7866d7 into slightly smaller chunks.
I will ask web devs if they remember, but it won't be on critical path.
Identified base template from jekyll new for v3.1.6: https://github.com/jekyll/jekyll/tree/v3.1.6/lib/site_template
This does not look anything like the base that is used for our newer website.
(As noted in integration PR)
Per Slack conversation: https://drakedevelopers.slack.com/archives/C01879RNKQW/p1612374479018500?thread_ts=1612374025.015800&cid=C01879RNKQW
The website template came from: https://jekyllthemes.io/theme/made-portfolio-jekyll-theme
We will now take steps in doing a best-effort purge of this template from our Git history.
Working: Adding video here to avoid polluting git history:
https://user-images.githubusercontent.com/26719449/108152577-4d14f300-70a7-11eb-88c5-5da0c39b1e24.mp4