Draft-js: Package "immutable" should be placed in "peerDependencies".

Created on 6 Jun 2017  路  6Comments  路  Source: facebook/draft-js

good first issue help wanted
Source
picture lixiaoyan
👍3

All 6 comments

taking this up 馃憤

arshadkazmi42 picture arshadkazmi42 on 4 Oct 2018

Should it be? What if I use another package with older immutable version? My app will be completely broken and I won't be able to fix it.

What problem are you trying to solve here? It's not clear from your issue.

TrySound picture TrySound on 5 Oct 2018
👍1

@TrySound I am new to this repo, I thought its already discussed issue, so I took it up.
not sure why this is needed?
May be @lixiaoyan can help us understand, why we need this change

arshadkazmi42 picture arshadkazmi42 on 5 Oct 2018
👍1

@flarnie, @claudiopro, @mrkev, @elboman - would any of you happen to know if this is needed? My guess is that this is fine as is, but I don't know too much about dependencies :)

niveditc picture niveditc on 6 Oct 2018

Okay, since no one has any input, looks like this might not actually be needed. @arshadkazmi42 - apologies for the mislabeled issue!

niveditc picture niveditc on 10 Oct 2018

Ok. No issues at all. I will explore through the other open bugs . Thanks

arshadkazmi42 picture arshadkazmi42 on 10 Oct 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

snaerth picture snaerth  路  3Comments
steviesama picture steviesama  路  3Comments
darklightblue picture darklightblue  路  3Comments
jackmatrix picture jackmatrix  路  3Comments
liran319 picture liran319  路  3Comments