Draft-js: write a unit test for conversion functions

Created on 16 Sep 2016  路  1Comment  路  Source: facebook/draft-js

We had a recent issue with convertFromRaw, where a typo caused the code to fail. a unit test for this function would be super helpful

help wanted
Source
picture stopachka

Most helpful comment

Hey @stopachka,

I took a crack at this here: https://github.com/nrbernard/draft-js/commit/77a3f3e4dd90ea92663fd5d84b7446b891a8d580. Before I submit a PR, I was just curious if you had more/different test cases in mind or what specifically that typo bug was that I could add a test for. I'm also happy to add similar tests for convertToRaw.

Thanks!

picture nrbernard on 5 Nov 2016
👍2

>All comments

Hey @stopachka,

I took a crack at this here: https://github.com/nrbernard/draft-js/commit/77a3f3e4dd90ea92663fd5d84b7446b891a8d580. Before I submit a PR, I was just curious if you had more/different test cases in mind or what specifically that typo bug was that I could add a test for. I'm also happy to add similar tests for convertToRaw.

Thanks!

nrbernard picture nrbernard on 5 Nov 2016
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

igorpreston picture igorpreston  路  3Comments
abeq picture abeq  路  3Comments
jackmatrix picture jackmatrix  路  3Comments
ianstormtaylor picture ianstormtaylor  路  3Comments
steviesama picture steviesama  路  3Comments