Draft-js: Why inline styles are uppercase and other operations are lowercase

Created on 14 Mar 2016  路  6Comments  路  Source: facebook/draft-js

Was wondering why the inline commands are on the format UNDERLINE BOLD ITALIC and the blockmode operations are header-one, header-two.

Would be great if we could use them either on a consistent way or case insensitive.

enhancement question

Most helpful comment

@hellendag How about we refactor the codebase to put everything lowercase, but still allow case insensitive to avoid breaking changes ?

All 6 comments

Great question. This is due to refactoring over time, and is not intentional. Personally, I prefer the lowercase values.

@hellendag How about we refactor the codebase to put everything lowercase, but still allow case insensitive to avoid breaking changes ?

we could also somehow mark as deprecated the usage of upper-case commands

@mitermayer That sounds good to me.

having a look on this issue now, the problem that we have is that in order to have backwards support we would need to do a bunch of toLowerCase() in many different places since we don't yet have a centralized reference for inlineStyles matching. I wonder if we want to still proceed with backwards compatibility in this regards or we can just lower case everything else internally. @hellendag

Closing this for now

Was this page helpful?
0 / 5 - 0 ratings