One thing that could really help with performance is if we window the scrollable area for the autocomplete. I'm thinking that we could either just have an example of how to use this with react-virtualized _or_ if it's not too complex, we could include our own miny implementation of windowing. Thoughts/ideas appreciated!
kentcdodds
All 7 comments
I like the idea of pointing to an example. Or maybe a component that wraps react-tiny-virtual-list could be cool. Then it could be installed separately.
souporserious
on 26 Jul 2017
Happy to try and work on a react-virtualized example if nobody already has
tizmagik
on 26 Jul 2017
Please do!
kentcdodds
on 27 Jul 2017
Feel free to do this, but I don't want to keep this issue open.
I've decided that windowing is out of scope for downshift (heck, it doesn't even know that you're rendering a list of things really, you do all that rendering stuff yourself).
kentcdodds
on 8 Aug 2017
@tizmagik if you don't mind can you share sample code downshift+react-virtualized
abumuawiyah
on 7 Jan 2019
I'm guessing this example will be very similar to react-virtualized: https://codesandbox.io/s/github/kentcdodds/downshift-examples/tree/master/?module=%2Fsrc%2Fother-examples%2Freact-window%2Findex.js&moduleview=1
kentcdodds
on 7 Jan 2019
I'm guessing this example will be very similar to react-virtualized: https://codesandbox.io/s/github/kentcdodds/downshift-examples/tree/master/?module=%2Fsrc%2Fother-examples%2Freact-window%2Findex.js&moduleview=1
Cool. Thanks.
abumuawiyah
on 8 Jan 2019
Related issues
srishanbhattarai
路
3Comments
gsimone
路
3Comments
GuidovdRiet
路
3Comments
jlongster
路
4Comments
glockjt
路
3Comments