Downshift: Support preact out of the box

Created on 26 Jul 2017  路  2Comments  路  Source: downshift-js/downshift

@zouhir says he'll be working on this a bit :)

enhancement help wanted

Most helpful comment

If you rebase your branch onto master that should now be resolved :+1:

All 2 comments

I had a bit of time to work on this.

my solution includes having a /src/compat/comapt-lite.js and /src/compat/prop-type.js to insure Preact's compatibility with proptypes and the React component.

Also, in rollup config, I did alias the react & prop-types to those 2 files in source.

Blocker:
The React rolled up version of this has a bit of an issue (pure react, no alias entry, no change)

  • 馃榿 component loads fine!
  • 馃榿 I can click and see drop down fine!
  • 馃様 When I choose a country I get the Error attached. I am afraid it's some babel or something else.

Since I've not fiddled much with react libs in details recently, appreciate looking at this error am getting:

screen shot 2017-07-26 at 15 15 57

I'll share my WIP branch here as well

If you rebase your branch onto master that should now be resolved :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kentcdodds picture kentcdodds  路  3Comments

alexandernanberg picture alexandernanberg  路  4Comments

preraksola picture preraksola  路  4Comments

the-simian picture the-simian  路  4Comments

kohgpat picture kohgpat  路  3Comments