Dosbox-staging: macOS: User config file is reset on every launch

[morellam-dev]

When launching the macOS build on Catalina 10.15.3 without any parameters, the file dosbox-staging.conf is being overwritten with the default configuration, even if it already exists.

$ ./dosbox
dosbox-staging version 0.75.0-rc1
---
CONFIG: Generating default configuration
CONFIG: Writing it to /Users/myusername/Library/Preferences/DOSBox/dosbox-staging.conf
CONFIG: Loading primary file /Users/myusername/Library/Preferences/DOSBox/dosbox-staging.conf
...

When the path is passed into the -conf parameter, it launches as normal, and uses the configuration file as given. This resolves the issue, but aside from creating custom automator tasks, there's no easy way to launch the app bundle with this parameter given.

$ ./dosbox -conf /Users/myusername/Library/Preferences/DOSBox/dosbox-staging.conf
dosbox-staging version 0.75.0-rc1
---
CONFIG: Loading primary file /Users/mmorella/Library/Preferences/DOSBox/dosbox-staging.conf

I'm not savvy enough to figure out exactly what the issue is, but i reckon it has to do with the config loading behavior at the bottom of /src/gui/sdlmain.cpp

[dreamer]

Thank you for the report. This is exactly kind of problems, that we didn't catch ourselves during testing, and why I wanted to do RC1 before final release :)

Setting this as critical bug necessary for 0.75.0 final.

[dreamer]

@MozzarellaM The problem is fixed on the master branch (GitHub automatically closed the issue the moment I merged it in) - you can test it in our development snapshot builds.

The fix was backported to 0.75.x branch and will be included in 0.75.0 final release.

If not for this report, we would've released stable builds with a pretty critical this bug in place.

If the problem returns in any way, shape or form - reopen this issue (or ask for it to be reopened).

Thank you! :)

[kcgen]

Appears to have come from upstream: https://www.vogons.org/viewtopic.php?t=73545

[dreamer]

In this case, I am quite sure it was my fault :) The same path for storing configuration files was hardcoded in 2 different places, and I modified only one. Perhaps upstream had a similar problem on branch 0_74…

Anyway, now the macOS path is written down in one place only, so it can't happen again; I tested on VM and it worked, but more testing will be appreciated of course :).