Doorkeeper: Log in fails, and reports missing translation

[jasonivers]

Steps to reproduce

Update to 5.2 from 5.1

The more detailed the issue, the more likely that we will fix it ASAP.

Don't use GitHub issues for questions like "How can I do that?" —
use StackOverflow
instead with the corresponding tag.

Expected behavior

I should log in successfully

Actual behavior

Updating to the most recent version this morning caused an error with a missing translation, and then failed to login, and had an error message that had #{value}, presumably meaning it was used as a string literal rather than being interpreted.

The missing translation was doorkeeper.errors.messages.invalid_request.missing_param

Rolling back to 5.1 fixed the problem

System configuration

You can help us to understand your problem if you will share some very
useful information about your project environment (don't forget to
remove any confidential data if it exists).

Doorkeeper initializer:

Ruby version:
2.6.3

Gemfile.lock:

[nbulaj]

Hi @jasonivers . Thanks for reporting the issue. It's related to #1306

Could you please try to use master branch of this repo and check if it works?

[nbulaj]

Released as 5.2.1, let me know if it fixed the issue!

[mjankowski]

I had this same issue, and updating to 5.2.1 does fix that specific error.

Sort of related -- will there be an upgrading instructions section update for 5.2.x in the wiki? Is it now required to explicitly set default_scopes in the config (or otherwise interact with scopes in a way that wasn't previously required?). Despite that locales issue being fixed I'm still getting some other errors, and am not sure yet if it's something I need to change in my specs, or a doorkeeper config I need to change.

[nbulaj]

Yep, @mjankowski , I need to check all the PRs and collect changes to write migration guide. I'll try to do it ASAP, but don't sure how fast it would be :(

[jasonivers]

Apparently it is fixed when both updating and adding default_scopes.

[nbulaj]

I think we can close this issue for now. Thanks for reporting!

[ansonhoyt]

I'm still getting the missing translation error when default_scopes isn't configured.

ActionView::Template::Error: missing translation: doorkeeper.errors.messages.invalid_request.missing_param

I wouldn't expect default_scopes to be required since it defaults to :public per the Scopes guide and Using Scopes.

I just upgraded now that https://github.com/doorkeeper-gem/doorkeeper-openid_connect/pull/85 was merged and released, and my auth tests started failing 😄

[ansonhoyt]

My mistake, I found that the install_generator.rb copies en.yml to my project. So I re-ran rails g doorkeeper:install and got the missing translation. 🎉

I'll keep an eye out for @nbulaj to land the migration guide in case I miss anything else.