Doom-emacs: mu4e-maildirs-extension is broken with the latest update of mu4e

[haji-ali]

What did you expect to happen?
After updating mu to the latest version (mu version is: 1.3.8, commit: ac164b7e262af0d044714f5a6add71508cf5e5d9), I expected the mu4e mail app to run smoothly.

What actually happened?
The error below is displayed instead.

Additional details:
Messages

error in process filter: ad-Advice-search-backward: Search failed: "
  Misc"
error in process filter: Search failed: "
  Misc"

backtrace


Debugger entered--Lisp error: (search-failed "\n  Misc")
  #<subr search-backward>("\n  Misc" nil nil nil)
  ad-Advice-search-backward(#<subr search-backward> "\n  Misc")
  apply(ad-Advice-search-backward #<subr search-backward> "\n  Misc")
  search-backward("\n  Misc")
  mu4e-maildirs-extension-update()
  mu4e-maildirs-extension-main-view-handler()
  run-hooks(change-major-mode-after-body-hook special-mode-hook mu4e-main-mode-hook)
  apply(run-hooks (change-major-mode-after-body-hook special-mode-hook mu4e-main-mode-hook))
  run-mode-hooks(mu4e-main-mode-hook)
  mu4e-main-mode()
  mu4e~main-view()

Steps to reproduce:

1. Enable the mu4e mail app
2. Make sure to have the latest mu4e (mu version is: 1.3.8, commit: ac164b7e262af0d044714f5a6add71508cf5e5d9)
3. Start emacs
4. Go to mail app

System information:

emacs   version    26.3
        features   XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD LCMS2
        build      Sep 16, 2019
        buildopts  (--build=x86_64-linux-gnu --prefix=/usr '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' --sysconfdir=/etc --localstatedir=/var --disable-silent-rules '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --sharedstatedir=/var/lib --program-suffix=26 --with-modules --with-file-notification=inotify --with-mailutils --with-x=yes --with-x-toolkit=gtk3 --with-xwidgets --with-lcms2 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs26-TP6iDo/emacs26-26.3~1.git96dd019=. -fstack-protector-strong -Wformat -Werror=format-security -no-pie' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro -no-pie')
        windowsys  x
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop, origin/develop, origin/HEAD 56cba7828 2020-02-27 23:27:50 -0500
        dir        ~/Work/Projects/home-conf/doom.d/
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /bin/zsh
        uname      Linux 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64
        path       (~/bin ~/.local/bin /usr/local/sbin /usr/local/bin /usr/sbin /usr/bin /sbin /bin /usr/games /usr/local/games /snap/bin /usr/lib/x86_64-linux-gnu/emacs/26.3/x86_64-linux-gnu)
config  envfile    nil
        elc-files  0
        modules    (:completion company (ivy +icons) :ui workspaces doom hl-todo modeline treemacs vc-gutter (window-select +switch-window) :editor fold multiple-cursors rotate-text snippets :term eshell term :emacs (dired +icons) electric :checkers syntax spell :tools eval (lookup +docsets) magit make :lang (cc +irony +rtags) data emacs-lisp (latex +latexmk) markdown (org +attach +babel +capture) python (sh +fish) swift :email mu4e :app calendar regex :config literate (default +bindings +smartparens))
        packages   ((mu4e-alert) (hungry-delete) (yasnippet-snippets) (edit-server) (org-clock-today) (beacon) (dired-subtree) (dired-single) (fancy-narrow) (org-super-agenda) (xterm-color) (openwith) (persistent-scratch) (rotate) (smartrep))
        unpin      (n/a)
        elpa       (matlab-mode)

[hlissner]

This doesn't appear to be a Doom issue and should be reported upstream. mu4e-maildirs-extension-update appears to call search-backward, and allows it throw an error if the search fails, without catching it.

[haji-ali]

The bug is in mu4e-maildirs-extension not mu4e. It also seems that mu4e-maildirs-extension is not maintained anymore which is why I had to modify doom to not include this package.

[hlissner]

As of 5b094b6 I've removed mu4e-maildirs-extension from the :email mu4e module, which should resolve this issue. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

[seanfarley]

I'm adding this functionality to core mu4e which can be tracked here: https://github.com/djcb/mu/pull/1586