Doom-emacs: Recursive load workspaces.el

[zeronone]

Observed behavior

Latest develop branch gives the following error and fails to start emacs.

Steps to reproduce

1. Select these example steps,
2. Delete them,
3. And replace them with precise steps to reproduce your issue.

System information

• Mac OSX 10.12
• GNU Emacs 25.3.1

[areinisc]

I am attempting to try doom-emacs for the first time and I am encountering the same issue. I started by following the install guide, but with lots of fatal errors during the make install step, I looked into the open issues. It seems like there are lots of things that are fixed in develop but not in master. So I switched to the develop branch. make install worked perfectly, but now emacs opens with this recursive error shown in @zeronone's screenshot.

Steps to reproduce

1. Install emacs
   brew tap d12frosted/emacs-plus brew install emacs-plus brew linkapps emacs-plus
2. Clone doom-emacs, switch to develop branch, and install
   git clone https://github.com/hlissner/.emacs.d ~/.emacs.d cd ~/.emacs.d git checkout --track origin/develop cp init.example.el init.el make install
3. Open emacs
   open -a /Applications/Emacs.app

System Info

• Mac OSX 10.12.6
• GNU Emacs 25.3
• make info output
  ```
  
  
  
  • OS: darwin (x86_64-apple-darwin16.7.0)
  
  
  • Emacs: 25.3.1 (Sep 15, 2017)
  
  
  • Doom: 2.0.9 (develop https://github.com/hlissner/doom-
    
    emacs/commit/850acebad1d1784e52c5ade3a2426ca0874e82cb)
  
  
  • Graphic display: nil (daemon: nil)
  
  
  • System features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB
    
    TOOLKIT_SCROLL_BARS NS MODULES
  
  
  • Details:
    
    elisp uname -a: Darwin Alexs-MacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Wed Oct 4 00:17:00 PDT 2017; root:xnu-3789.71.6~1/RELEASE_X86_64 x86_64 modules: n/a packages: (ac-alchemist ace-link ace-window adaptive-wrap alchemist all-the-icons anaconda-mode android-mode async auctex auth-password-store auto-compile auto-yasnippet avy (centered-window :recipe (centered-window :fetcher github :repo anler/centered-window-mode)) cider clj-refactor cmake-mode coffee-mode command-log-mode company company-anaconda company-auctex company-dict (company-glsl :recipe (company-glsl :fetcher github :repo Kaali/company-glsl)) company-go company-inf-ruby company-irony company-irony-c-headers company-lua company-php company-quickhelp company-racer company-restclient company-shell company-sourcekit company-statistics company-tern company-web counsel counsel-css counsel-dash counsel-projectile crystal-mode csharp-mode cuda-mode demangle-mode devdocs dired-k disaster dockerfile-mode doom-themes dumb-jump editorconfig elixir-mode elm-mode (emacs-snippets :recipe (emacs-snippets :fetcher github :repo hlissner/emacs-snippets :files (*))) emmet-mode ensime eslintd-fix ess ess-R-data-view ess-smart-equals evil evil-anzu evil-args evil-collection evil-commentary evil-easymotion evil-embrace evil-escape evil-exchange evil-goggles evil-indent-plus evil-ledger evil-matchit evil-mc evil-multiedit evil-numbers evil-org evil-snipe evil-surround evil-textobj-anyblock evil-vimish-fold evil-visualstar (exec-path-from-shell :ignore nil) expand-region flycheck flycheck-cask flycheck-crystal flycheck-elm flycheck-irony flycheck-ledger flycheck-perl6 flycheck-plantuml flycheck-popup-tip flycheck-pos-tip flycheck-rust flyspell flyspell-correct flyspell-correct-ivy fringe-helper gist git-gutter-fringe git-link git-timemachine gitconfig-mode gitignore-mode glsl-mode go-eldoc go-guru go-mode gorepl-mode groovy-mode haml-mode haskell-mode haxor-mode helpful hide-mode-line highlight-indentation highlight-numbers highlight-quoted hindent hl-todo htmlize hy-mode hydra imenu-anywhere imenu-list impatient-mode inf-crystal inf-ruby intero irony irony-eldoc ivy ivy-bibtex ivy-hydra ivy-rich ivy-rtags ivy-xref js2-mode js2-refactor json-mode julia-mode ledger-mode less-css-mode lua-mode macrostep makefile-executor markdown-mode markdown-toc meghanada merlin mips-mode modern-cpp-font-lock moonscript multi-term nasm-mode nav-flash neotree nlinum nlinum-hl nlinum-relative nodejs-repl nose ob-crystal ob-go ob-mongo ob-rust ob-sql-mode ob-translate omnisharp opencl-mode (org-bullets :recipe (org-bullets :fetcher github :repo Kaligule/org-bullets)) org-download org-plus-contrib org-tree-slide (osx-clipboard :ignore nil) overseer ox-pandoc ox-reveal pass password-store pcre2el pdf-tools perl6-mode persistent-soft persp-mode php-boris (php-extras :recipe (php-extras :fetcher github :repo arnested/php-extras)) php-mode php-refactor-mode phpunit pip-requirements plantuml-mode prodigy projectile psc-ide pug-mode purescript-mode quelpa quickrun racer rainbow-delimiters rainbow-mode rake restclient rjsx-mode (rotate-text :recipe (rotate-text :fetcher github :repo debug-ito/rotate-text.el)) rspec-mode rtags ruby-refactor rust-mode sass-mode sbt-mode scala-mode shackle shader-mode shrink-path skewer-mode slime smart-forward smartparens smex solaire-mode ssh-deploy stylus-mode swift-mode swiper tern tide toc-org toml-mode tuareg typescript-mode undo-tree use-package vi-tilde-fringe vimrc-mode visual-fill-column web-beautify web-mode wgrep which-key xref-js2 yaml-mode yard-mode yasnippet) elc dirs: n/a exec-path: (/usr/local/GMTSAR/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /opt/X11/bin /Library/TeX/texbin /usr/local/Cellar/emacs-plus/25.3/libexec/emacs/25.3/x86_64-apple-darwin16.7.0)
  
  

[hlissner]

I'm able to reproduce this. It appears to be a bug on Emacs 25.3 on MacOS, and doesn't appear on Emacs 26 or on Linux. I'll look into this.

[hlissner]

And done! This has been fixed in develop. Let me know if that isn't the case!

I'll leave this issue open until it gets merged into master.

[zeronone]

@hlissner Yep, it is fixed. 👍

[russmatney]

Thanks for the quick fix!

Sadly, I'm hitting another Recursive load: ".emacs.d/core/autoload/buffers.el":

Upgrading to emacs 26 fixed it for me - to anyone looking to do that, on OSX that means downloading the 26.0.91-1 pretest at emacs for osx and/or brew upgrade --devel emacs/brew upgrade --devel emacs-plus

[hlissner]

@russmatney Hmm, I'm unable to reproduce your issue on Emacs 25.3 on MacOS. Do you have your config up on github somewhere where I can see it?

[russmatney]

@hlissner I had some trouble reproducing but was finally able to - seeing this issue plus a handful of errors in emacs 25.3. Error output at startup:

Error (use-package): smartparens/:catch: Invalid byte opcode: op=183, ptr=11
Error (use-package): evil/:config: Invalid byte opcode: op=183, ptr=34
Error (use-package): evil-visualstar/:init: Invalid byte opcode: op=183, ptr=2
Error (use-package): ivy/:catch: Symbol’s function definition is void: record
Warning (initialization): An error occurred while loading ‘/Users/dot/.emacs.d/init.el’:

error: Invalid byte opcode: op=183, ptr=2

To ensure normal operation, you should investigate and remove the
cause of the error in your initialization file.  Start Emacs with
the ‘--debug-init’ option to view a complete error backtrace.
Error (doom-init-hook): void-function in ’ivy-mode’ -> Symbol’s function definition is void: record
Error (doom-init-hook): void-function in ’savehist-mode’ -> Symbol’s function definition is void: record
Error (doom-init-hook): error in ’doom|init-ui’ -> Recursive load: "/Users/dot/.emacs.d/core/autoload/buffers.el", "/Users/dot/.emacs.d/core/autoload/buff...

The recursive load is not an issue for me on 26.0.91, instead i'm seeing a handful of use-package errors:

Error (use-package): helm/:catch: Assertion failed: (not (symbolp body))
Error (use-package): haskell-mode/:catch: Wrong type argument: cl-slot-descriptor, [cl-struct-cl-slot-descriptor file unbound string nil]
Error (use-package): flow-minor-mode/:catch: Wrong type argument: cl-slot-descriptor, [cl-struct-cl-slot-descriptor file unbound string nil]
Error (use-package): rjsx-mode/:catch: Wrong type argument: cl-slot-descriptor, [cl-struct-cl-slot-descriptor file unbound string nil]
Error (use-package): graphql-mode/:catch: Wrong type argument: cl-slot-descriptor, [cl-struct-cl-slot-descriptor type (quote netrc) symbol ((:documentation . "The backend type.") (:custom . symbol) (:group default))]
Error (use-package): ivy/:catch: Wrong type argument: cl-slot-descriptor, [cl-struct-cl-slot-descriptor type (quote netrc) symbol ((:documentation . "The backend type.") (:custom . symbol) (:group default))]
Error (use-package): ivy-hydra/:init: Symbol’s value as variable is void: ivy-minibuffer-map
Error (doom-init-hook): void-function in ’ivy-mode’ -> Symbol’s function definition is void: ivy-mode

Notably these are showing up on my home machine, but not my work computer, wherever everything on emacs 26 is all hunky dory. not sure yet what the difference there is. I'm on the latest doom develop branch, and just nuked and reinstalled my .local/ to be sure it wasn't anything hanging around.

My config is here: https://github.com/russmatney/doom.d/tree/develop. Forgive the mess, i'm, uh, between clean configs at the moment - hoping to clean it up into a more presentable ~/.doom.d soon! (everyone on our team is built on doom at this point :D Thanks for the awesome work, we're huge fans!)

[hlissner]

Since the original issue is resolved (and I'm preparing to merge into master), I'll close this.

@russmatney Are you still experiencing these issues? A lot has changed in Doom land. Perhaps it's been fixed along the way.