Doom-emacs: Cannot toggle line number styles if initially disable it

[nightire]

I put this setting in private module to not display line number after emacs startup:

(setq doom-line-numbers-style nil)

it works as I expected, however SPC t l cannot toggle line number afterwards.

I think doom-line-numbers-style implies ppl to change the style of line number, but it actually turn off the line number completely.

It doesn't make sense to me, or I misused this variable completely?

Another related question is: how to switch to relative line number mode by using SPC t l?

[averrin]

And maybe its other bug, but if i set it to 'relative its completely off. Then when i press spc t l emacs said "no line numbers plugin found"…

[tasmo]

Have exactly the same issue like @averrin.

The space for displaying line number is added but with the buffer's default background and no content.

[hlissner]

This was a bug. The fix is now in develop. doom/toggle-line-numbers now:

• Cycles through the three styles of line numbers (normal, relative and disabled), starting from doom-line-numbers-style's initial value, and
• Properly enables the line numbers if doom-line-numbers-style is nil.

Let me know if it still gives you trouble! I'll leave this issue open until it gets merged into master.

[dsdshcym]

There is a new style for display-line-numbers-mode: visual, which is basically like relative but counts screen lines instead of buffer lines.

Can we also support that option? It works better for modes like org-mode

(`visual   '(visual t nil))

[hlissner]

Just added support for visual, but with a separate variable: doom-line-numbers-visual-style. Set this to non-nil and display-line-numbers will use visual behind the scenes. It has no effect on nlinum though (and can't; nlinum-relative doesn't provide this capability).

On another note, how new is visual? Was that introduced in 26 or 27?

[dsdshcym]

It was introduced in 26, basically at the same time as display-line-numbers

[tasmo]

After pulling the develop branch (Emacs 25.3) and executing make I get the error message:

Deleted old autoloads.el
File mode specification error: (void-function nlinum-relative-on)

In my private/ui/init.el I have:

(setq doom-line-numbers-style 'relative)

Switching the line number's style with SPC t l brings the messages:

Switched to disabled line numbers
let: Symbol’s function definition is void: nlinum-relative-off
let: Symbol’s function definition is void: nlinum-relative-on

[hlissner]

Ah, my mistake, forgot to update nlinum-relative's autoloads. It is now fixed.