Dokuwiki: E-mail notifications for page changes include wrong "New Revision:" link.
E-mail notifications for page changes include wrong "New Revision:" link. More specifically, it seems that it is missing the correct ?rev= argument, probably due to 'NEWPAGE' => wl($id, '', true, '&'), at https://github.com/splitbrain/dokuwiki/blob/master/inc/subscription.php#L397. This generates a link to the newest (most current) revision of the article, rather then the revision directly after the change.
jaakristioja
All 7 comments
The question is: should we "fix" this? Currently the link will go to the most current version of the page. When we add a the revision, the link may go to a now outdated version of the page.
For example, I might get a mail for a change and see there's a typo in it. So I follow the link and edit the typo. If the link goes to the revision the mail mentions I might accidentally edit a version that has been edited in the meantime. I would fix the error but accidentally reverting other changes.
splitbrain
on 3 Jan 2018
Maybe changing to "New" "Current" is a good option
mprins
on 3 Jan 2018
Providing all three links would also be an option.
jaakristioja
on 3 Jan 2018
For me, comparing with the last version is the most practical (but also knowing that some versions existed in between).
So why not send just a link to the last version (as it was before), but also saying that "The page was changed {N} times".
Thus anyone interested in intermediate versions could just check them in the page's history.
chang-zhao
on 5 Jan 2018
The email is directly sent after creating the new page version, not after {N} times changes of the page...
Klap-in
on 5 Jan 2018
Ah, I got it. I thought the confusion was because of some "digest" mode like notifying once a day. Sorry. Then it might be sensible to send a link directly to page history - diff with the current version, like
https://www.dokuwiki.org/dokuwiki?rev=1429463799&do=diff
Then it's probably easy to see diff with other versions too?
chang-zhao
on 5 Jan 2018
Old versions have a "This is an old revision of the document!" message on the top of the page, and the user can use that to prevent such mistakes.
So maybe we can just use the revisioned link and add a hint in the email like "There may be newer changes after this revision, which is shown on the top of the page if this happens".
phy25
on 5 Jan 2018
Related issues
epeios-q37
路
4Comments
splitbrain
路
4Comments
qezwan
路
3Comments
michitux
路
5Comments
schplurtz
路
5Comments
Most helpful comment
Old versions have a "This is an old revision of the document!" message on the top of the page, and the user can use that to prevent such mistakes.
So maybe we can just use the revisioned link and add a hint in the email like "There may be newer changes after this revision, which is shown on the top of the page if this happens".