Dokuwiki: Please add classes to elements with IDs

Created on 24 Nov 2017 · 11Comments · Source: splitbrain/dokuwiki

As designer/front end developer I won't style any ID, because that's not how we do frontend in 2017.

https://github.com/splitbrain/dokuwiki/blob/0f8cc87bd3c00da5e455ea3abf06e9893c9b9d70/inc/html.php#L2102
Please replace <div id="dw__toc"> with <div id="dw__toc" class="dw__toc">

Or provide ways to hook the output or at least to add classes.

CSS XHTML JS Browsers good first issue

Source

bitstarr

👎2

Most helpful comment

@bitstarr It makes perfect sense to just use ID there. TOC is unique element.

I would argue that it is against "how we do frontend in 2017" to just duplicate ID name into class because it just spams html. Seems a bit demagoguery.

Is specificity a problem or what?

iskrisis on 29 Nov 2017

👍2

All 11 comments

Good idea. A pull request is welcome of course :)

Klap-in on 25 Nov 2017

You are right, but at the moment I'm trying to build a template and I have no experience with the code of dokuwiki. I simply saw the shortcomings for providing quality styling.

I hope someone who is more involved will help out.

bitstarr on 27 Nov 2017

👎2

If you spot more, please add them here :)

Klap-in on 27 Nov 2017

@bitstarr It makes perfect sense to just use ID there. TOC is unique element.

I would argue that it is against "how we do frontend in 2017" to just duplicate ID name into class because it just spams html. Seems a bit demagoguery.

Is specificity a problem or what?

iskrisis on 29 Nov 2017

👍2

Yes, specifity is still a big deal for writing sane and reusable CSS. Also the spearation of concerns is a best practice.

bitstarr on 29 Nov 2017

@bitstarr It's your itch, please either scratch it by providing a PR or enjoy it in silence.