Docz: yarn packages fail (following contributing guidelines)

Created on 22 Mar 2019  路  10Comments  路  Source: doczjs/docz

Trying to contribute on the 1.0.0-rc.3 but following the contributing guidelines doesn't work :(

yarn bs
yarn packages --> fail 馃槩

Node version: v10.13.0
Yarn version: 1.15.2

v1

Most helpful comment

Fixed, will be release today :)

All 10 comments

Can you show me the error @ivan-dalmet ?

image

image

@pedronauck It's a fresh new fork (I removed my old one and started from scratch)

The problem comes from the snapshots

Thanks for filing an issue about this @ivan-dalmet.

I also just experienced this whilst working on the project. The snapshot tests will fail for everyone because the absolute path to an example fixture is stored in the snapshot.

Unless us users are storing docz at the exact same location in our filesystem as @pedronauck then the snapshots will always fail for us. You can work around this by running yarn test -u in other-packages/babel-plugin-export-metadata but make sure you don't commit the updated snapshot with any changes you make 馃挭

I wonder if there's a way to strip out the part of the file path for the tests so that tests can pass on everyone's machine - taking a look to see if I can help out with this.

Oh, my bad 馃 Thanks @Glazy, I'll check if I can help with this. It's a so much important thing!

I did take a look at the test but was unable to come up with a solution (thanks @pedronauck for commenting to remind me to follow up 馃槀).

Fixed, will be release today :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bichotll picture bichotll  路  3Comments

regrettably picture regrettably  路  3Comments

fenbka picture fenbka  路  3Comments

danburzo picture danburzo  路  3Comments

ssylvia picture ssylvia  路  3Comments