Docusaurus: Support for absolute customDocsPath

Created on 12 Mar 2019  路  6Comments  路  Source: facebook/docusaurus

Setting an absolute path as the customDocsPath doesn't work. This was unexpected to me as a user.

In many places path.join is being used (or even plain string concatenation), where I think path.resolve should be used, which would correctly work with an absolute path.

https://github.com/facebook/Docusaurus/blob/2da59ed4af381c905addabadac3aee7a0e45ef72/v1/lib/version.js#L118

starter good first issue v2

Most helpful comment

Unfortunately, I have become busy recently and I will no longer be able to work on this issue. If anyone else wants to take it up, the information the open pull request might come in handy.

All 6 comments

That's a good point. We're more mindful of this in v2 and do use path.resolve() where we are aware.

Feel free to submit a PR to fix this in the meanwhile!

cc @endiliey

I would like to work on this.

Unfortunately, I have become busy recently and I will no longer be able to work on this issue. If anyone else wants to take it up, the information the open pull request might come in handy.

I'd be interested in working on this.

@AndrewMayer thanks for your interest! But given the complexity of this task I think it wouldn't be worth the time and effort to implement this in v1. We're focusing our efforts on v2 instead now 馃槃

Wontfix in v1. Done via CLI in v2

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cheercroaker picture cheercroaker  路  3Comments

lex111 picture lex111  路  3Comments

JoelMarcey picture JoelMarcey  路  3Comments

awibox picture awibox  路  3Comments

MoogyG picture MoogyG  路  3Comments