Docusaurus: Try new Live Reload ports if default is taken

[JoelMarcey]

Is this a bug report?

Not really. Sort of.

Have you read the Contributing Guidelines on issues?

Yes

Environment

N/A

Steps to Reproduce

1. Run yarn start on a site
2. Run yarn start on another site

Expected Behavior

Both sites run.

Actual Behavior

The server port will get to 3001. But the Live Reload port errors out as duplicate.

Reproducible Demo

See steps to reproduce above

[endiliey]

Just gonna put the relevant codes/ tips to guide those who want to take this issue:

For now, the live reload had a fixed port as constant
https://github.com/facebook/Docusaurus/blob/49c27b733bf62506acff3c55f92143dc0ef3ed86/lib/server/server.js#L570-L575

Look at how we attempt to use different port when starting a server. Take inspiration from this & you'll solve this issue 😄
https://github.com/facebook/Docusaurus/blob/49c27b733bf62506acff3c55f92143dc0ef3ed86/lib/start-server.js#L52-L76

I'll be happy to help anyone who wanted to fix this issue

[vaibhavsingh97]

hi @JoelMarcey , can I take this up 😄
Looks like perfect place to start 👍

[endiliey]

@vaibhavsingh97 It's yours

[yangshun]

@vaibhavsingh97 It's yours!

I've added an "issue-claimed" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

I'll check in with you periodically so that we can keep the task updated with the progress.

[vaibhavsingh97]

yeah sure, Right now I am learning react as I am not familiar with it. I will try to fix after that.

[yangshun]

If I'm not wrong, this portion of the code doesn't require React knowledge; more of Node.js 😄

[vaibhavsingh97]

@yangshun Oh! yes, I will soon send a PR 😄

[vaibhavsingh97]

@yangshun @endiliey I had sent the PR https://github.com/facebook/Docusaurus/pull/769 😄
can you help me in testing, I don't know how can I do it? I have read the https://docusaurus.io/docs/en/installation.html but it talks about how can I install using npm or yarn

[JoelMarcey]

Hi @vaibhavsingh97 -- https://github.com/facebook/Docusaurus/tree/master/admin should give you some docs on how to test your changes either with Docusaurus or another project.

[vaibhavsingh97]

Thanks @JoelMarcey successfuly tested and fixed the bug 😄