Docusaurus: Duplicate code in readMetadata.js & versionFallback.js

[endiliey]

Is this a bug report?

No. Technical debt / better engineering. This is a very good first issue 😄

Have you read the Contributing Guidelines on issues?

Yes

Environment

Not applicable

Problem

Look at
https://github.com/facebook/Docusaurus/blob/d28b864a59fabeea45add8c090a13de7d0530de5/lib/server/versionFallback.js#L39-L81

and
https://github.com/facebook/Docusaurus/blob/d28b864a59fabeea45add8c090a13de7d0530de5/lib/server/readMetadata.js#L82-L122

Notes:

Be careful of circular importing because readMetadata.js requires versionFallback.js

https://github.com/facebook/Docusaurus/blob/d28b864a59fabeea45add8c090a13de7d0530de5/lib/server/readMetadata.js#L17

To be used at
https://github.com/facebook/Docusaurus/blob/d28b864a59fabeea45add8c090a13de7d0530de5/lib/server/readMetadata.js#L50

[ayshiff]

I would like to work on it ! 😀
Could you be a little bit more explicit on the problem to solve and how you want it to be solved ?

[endiliey]

It would be nice to refactor the code. Less code but same functionality.

cc @yangshun @JoelMarcey WDYT ?

[JoelMarcey]

@endiliey Yeah, this is a good idea.

Hi @ayshiff ...

I think one simple improvement you can make is to take the duplicate code and pull it out into its own file/module. Unless you are thinking of something else @endiliey ?