Docusaurus: Integrate prettier into our PR workflow

Created on 7 Dec 2017  路  3Comments  路  Source: facebook/docusaurus

Let's standardize on a single prettier config so we can... move fast!

feature

Most helpful comment

It looks like this issue can be closed: there is a .prettierrc, there are package.json scripts that use Prettier, and CircleCI is running the ci-check script.

All 3 comments

It looks like this issue can be closed: there is a .prettierrc, there are package.json scripts that use Prettier, and CircleCI is running the ci-check script.

Might also be nice to use something like husky to add a prepush hook that runs npm run prettier. That way lint can be caught before pushing as opposed to through the CI build failing.

@prescottprue Yes, I think that was part of the creation of this issue too, because you are right, we catch the failures after we push and thus have to patch with an updated fix if there is a failure.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cheercroaker picture cheercroaker  路  3Comments

awibox picture awibox  路  3Comments

endiliey picture endiliey  路  3Comments

JoelMarcey picture JoelMarcey  路  3Comments

philipmjohnson picture philipmjohnson  路  3Comments