I have something pretty much ready, and can issue a pull request to resolve this issue. However, the more I think about it, I think using lame would be the wrong approach.
Rationale:
lame is wav -> mp3 only. It does not cover flac.sox is good option, and allows streaming to it as wellffmpeg is an even better option because it can be used by both audio and video. @Islandora-CLAW/committers let me know what y'all think at your convenience. This is post MVP, so not a super priority, and I don't want to put it on a CLAW call until we're post MVP.
@ruebot you are right about lame, I think its out of copyright too 馃槣 .
ffmpeg is probably the way to go. We can _eventually_ have a bunch of API-X services to handle converting different file types. Also reduces the number of supporting applications we have to install.
@MarcusBarnes it's the commit above that says "Create audio service." You can get to the branch from that as well.
I think its out of copyright too
@whikloj are you talking about the mp3 patent that expired?
@ruebot umm...yeah that's the ticket. Either way your statement about lames singularity of focus means it could be easily replaced by a better tool, IMHO.
Since it came up in irc, here is the branch.
Linking to roadmap issues https://github.com/Islandora-CLAW/CLAW/issues/930 and https://github.com/Islandora-CLAW/CLAW/issues/929 for audio and video, respectively, if we go the ffmpeg route.
Resolved via https://github.com/Islandora-CLAW/Crayfish/commit/d81724ecb7485425cb763dd742baef79f42daeb5
Thx @Natkeeran!
Most helpful comment
@ruebot you are right about
lame, I think its out of copyright too 馃槣 .ffmpegis probably the way to go. We can _eventually_ have a bunch of API-X services to handle converting different file types. Also reduces the number of supporting applications we have to install.