Docs: Fix sqlalchemy-basic-sample.py on Build a Python App with CockroachDB and SQLAlchemy

Created on 18 Aug 2020  路  5Comments  路  Source: cockroachdb/docs

Re: Build a Python App with CockroachDB and SQLAlchemy

Issue Description

there's a code smell for an unused variable i. Along with that, there are additional pylint warnings, please see this issue.

Suggested Resolution

The associated fixes are in this code

running the following against the code will repro as well show other warnings that may optionally need be fixed.

pylint sqlalchemy-basic-sample.py
A-sql C-doc-improvement O-sales-eng P-2 T-something-broken
Source
picture dbist

All 5 comments

Hello, I will like to work on this issue. Can you please assign it to me?

zuliatowoade picture zuliatowoade on 5 Oct 2020
👍1

@zuliatowoade Heads-up: If you are participating in Hacktoberfest, you might want to wait until Tuesday to open the PR. We haven't updated the repo as per the new rules yet.

Amruta-Ranade picture Amruta-Ranade on 5 Oct 2020

@zuliatowoade Update: Repo marked for hacktoberfest! Feel free to open a PR!

Amruta-Ranade picture Amruta-Ranade on 6 Oct 2020
👍1

@dbist I noticed the "Re:" link opens up the v20.1 version of the doc. Does this mean I am to fix only the v20.1 version?

Thanks

zuliatowoade picture zuliatowoade on 7 Oct 2020

20.1 and 20.2

Amruta-Ranade picture Amruta-Ranade on 7 Oct 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

bdarnell picture bdarnell  路  6Comments
dbist picture dbist  路  5Comments
dankellycockroach picture dankellycockroach  路  3Comments
yzdocs picture yzdocs  路  6Comments
jseldess picture jseldess  路  8Comments