Describe the change you'd like to see
Fix review comments from #2299
Additional context
Usually these should be fixed by the person opening a PR but in this case I am making an exception to get the content included at least.
abrennan89
All 10 comments
/assign @vmexalien
vmexalien
on 1 Sep 2020
actively working on this issue; still familiarizing before next steps
vmexalien
on 9 Sep 2020
Hey @vmexalien :slightly_smiling_face: just wondering if you've made any progress on this issue and if it should be targeted for early Oct? Thanks.
abrennan89
on 23 Sep 2020
@abrennan89 yes! Making progress and early Oct is exactly what I have in mind.
vmexalien
on 23 Sep 2020
@abrennan89 looks like I don't have write access to this repo. I was trying to make a branch. Forgive me, I am a total newbie
vmexalien
on 8 Oct 2020
Hi @vmexalien - please check out the https://knative.dev/community/contributing/ guidelines before you contribute.
Thanks.
abrennan89
on 8 Oct 2020
@vmexalien are you still working on this one?
abrennan89
on 3 Nov 2020
@abrennan89 yes but to be totally honest, I don't know what needs to be done next.
this is the related PR https://github.com/knative/docs/pull/2930
vmexalien
on 5 Nov 2020
@abrennan89 if you have any advice, I would love to hear it. Else, I am kind of stuck at this point.
vmexalien
on 19 Nov 2020
@vmexalien sorry I'm just looking at this now, it lgtm just waiting for Grant to fix the CLA issue so we can merge. Thank you!
abrennan89
on 1 Feb 2021
Related issues
lancerdima
路
3Comments
abrennan89
路
4Comments
richterdavid
路
6Comments
romankolpak
路
7Comments
Abhishek-kumar09
路
5Comments
Most helpful comment
@abrennan89 yes! Making progress and early Oct is exactly what I have in mind.