Docs: Custom domains doc only explains customizing default domain

[ahmetb]

https://knative.dev/docs/serving/using-a-custom-domain/

This doc is titled "Setting up a custom domain" but it actually only covers "Configuring the default domain".

It doesn't explain how can I expose my hello-go.default.example.com with a domain name I own like hello.com.

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[ahmetb]

/lifecycle frozen

[jonatasbaldin]

Hhey @ahmetb!

@bsideup wrote this article on how to create custom domains per Service: https://bsideup.github.io/posts/knative_custom_domains/

I'm thinking about documenting this process in the docs.

What do you think?

[bsideup]

@jonatasbaldin funny thing - I thought about contributing it to the docs but didn't find time yet :D

I was thinking about doing it this week, but if you do it first - feel free to! 👍

[jonatasbaldin]

hey, just made the docs! would love a review from you @bsideup

[ahmetb]

I don’t think that blog post quite explains my need. I am looking to map example.com to a ksvc. To do that, I guess you need to drop {{.Name}} because I don’t care about ksvc’s name in my domain?

[bsideup]

@ahmetb you can use the same approach as described in the blog post, just instead of using $subdomain.{{.Domain}} (where $subdomain is the label's value) you can replace it with just $domain

Something like:

apiVersion: v1
kind: ConfigMap
metadata:
  name: config-network
  namespace: knative-serving
data:
  domainTemplate: |-
    {{if index .Annotations "org.proj.domain" -}}
      {{- index .Annotations "org.proj.domain" -}}
    {{else if index .Annotations "org.proj.subdomain" -}}
      {{- index .Annotations "org.proj.subdomain" }}.{{.Domain-}}
    {{else -}}
      {{- .Name}}.{{.Namespace }}.{{.Domain-}}
    {{end -}}

[ahmetb]

I see. I think that’s the useful scenario docs should actually mention. 1:1 domain:ksvc mappings; not templates.