Docs: Progress not shown anymore

Created on 27 Mar 2019  Â·  7Comments  Â·  Source: dotnet/docs

I think to be fair you should have your final code, show the progress like in the original one!


Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Area - C# Guide Technology - Async Task P1 doc-enhancement up-for-grabs

All 7 comments

Good point @laurentkempe

That can be done by modifying the final snippet as follows:

int num = 0;
await foreach (var issue in runPagedQueryAsync(client, PagedIssueQuery, "docs"))
{
    Console.WriteLine(issue);
    num++;
    Console.WriteLine($"Received {num} issues in total");
}

The advantage of the async streams implementation is that the progress can be reported directly from the loop that's iterating the issue.

I've added this to the projects for community contributors, and added the "up for grabs" label.

@BillWagner I would be interested to do it! Should you assign me to it?

Done. @laurentkempe Thank you.

Thx! That was super fast!

Adding myself as an additional assignee so this shows up in my filters.

@laurentkempe Are you still interested in making a PR for this?

Damn, yeah sorry @BillWagner it went out of my head!
I might not be able to do it before my vacations, but will come back to it in August if it is ok!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

JagathPrasad picture JagathPrasad  Â·  3Comments

svick picture svick  Â·  3Comments

sdmaclea picture sdmaclea  Â·  3Comments

mekomlusa picture mekomlusa  Â·  3Comments

gmatv picture gmatv  Â·  3Comments