Docs: Could review.docs.microsoft.com become public?

Created on 30 Mar 2017 · 4Comments · Source: dotnet/docs

As far as I can tell, CI in this repo publishes each PR to https://review.docs.microsoft.com/, where it presumably looks the same as it will look on https://docs.microsoft.com/. This would be especially useful, since building with docfx locally has issues (the template is very different; getting API reference right is hard; it's slow).

But, it's not accessible to me (and I assume everyone else outside MS): when I try to access it, I get a 403 error (after logging in).

A recent example where I would use this are changes to package.md in https://github.com/dotnet/docs/pull/1825. I suspect it has issues, but it's hard for me to check, since I can't access https://review.docs.microsoft.com/en-us/dotnet/articles/core/packages?branch=pr-en-us-1825 (I found the URL in the publicly accessible CI log).

Another reason why this is annoying is that CI sends emails to the PR author, containing links to https://review.docs.microsoft.com/, effectively saying "hey, come check that your PR looks okay", which the author is unable to do, if they are not from MS.

Since I don't see any reason for this limitation (all the information in the PRs is public anyway), could https://review.docs.microsoft.com/ become public?

external

Source

svick

👍2

Most helpful comment

I understand your frustration @svick. Yes, that site only works with Microsoft credentials.
We've had discussions around this internally but not sure if we made any decisions or progress on that. I'll follow-up with the team.

/cc @dend @Rick-Anderson @danroth27

mairaw on 30 Mar 2017

👍2

All 4 comments

/cc @dend @Rick-Anderson @danroth27

mairaw on 30 Mar 2017

👍2

Also, @richlander was part of those discussions as well.

BillWagner on 30 Mar 2017

👍1

The docs build locally on the ASP.NET Core side. Is it just a tweak to make them build over here? I'd love to be able to build locally ... it is sooooooo much faster 🏃 over there when you want to see what they look like to build locally.

[EDIT] Reasoning from @mairaw: Perhaps working there because it's only one repo source to build ... and then it was all :cry: tears :cry: over here.