Dockstore: Export as ZIP fails in develop branchfor unpublished workflows

[coverbeck]

Bug Report

Clicking on the Export as Zip button on the Info tab of an unpublished workflow fails.

It fails because this line is using this.basePath instead of this.configuration.basePath like the WorkflowsService class that it extends does. Since this.basePath is set to http://localhost instead of http://localhost:8080 the call fails.

This works in production/staging and the master branch.

Steps to reproduce the behaviour

1. Log in to a local instance of the UI, http://localhost:4200
2. Go to My Workflows
3. Go to an unpublished workflow (create a hosted workflow if you don't have an unpublished workflow)
4. Open Chrome Dev Tools
5. Click the Export as Zip button
6. Nothing happens on the page; in dev tools, you'll see an OPTIONS call to http://localhost failed, which failed because the web service is running on http://localhost:8080.

┆Issue is synchronized with this Jira Bug
┆Issue Type: Bug
┆Sprint: Backlog
┆Issue Number: DOCK-208

[denis-yuen]

Random thought, is this due to a different web.yml used in compose setup vs what you have locally?
https://github.com/dockstore/compose_setup/blob/1.5.3/templates/dockstore.model.ts.template#L12

[coverbeck]

Further info -- dev build works if run in production mode. << This statement was incorrect. :( Prod mode also fails on dev build.

[coverbeck]

This is failing because we are now using openapi-generator-cli instead of swagger-codegen-cli. swagger-codegen-cli generates code like this, using this.basePath:

        return this.httpClient.get<Array<Workflow>>(`${this.basePath}/workflows/published`,

whereas the openapi generator does this, using this.configuration.basePath

        return this.httpClient.get<Array<Workflow>>`${this.configuration.basePath}/workflows/published`,

src/app/shared/extended-workflows.service.ts file is modeled after and extends the generated code, and is still using this.basePath.