docker-sync start when already started raises an exception

[anlek]

Error

When you run docker-sync start and the sync is already running, you get an error:

tasks/sync/sync.thor:159:in `daemonize': undefined method `empty?' for nil:NilClass (NoMethodError)

In the earlier version, if you called docker-sync start when it was already running, it would respond with "Sync already running" (or something like that).

docker-sync version

0.5.13

Docker Driver

N/A

Sync strategy

N/A

your docker-sync.yml

N/A

OS

MacOS 10.14.6

[martmull]

I have got the same error since this morning

[dimonixx]

Me too

[Maxooo]

Same behavior here after the Mac OSX Catalina (10.15.1) update.

Configuration key | Value
----------|----------
docker-sync | 0.5.13
ruby | 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin19]
docker| 2.1.0.4 (Docker Desktop)
Sync strategy | native_osx
Mac OSX Catalina | 10.15.1

I also noticed some Unison spawn instability with the same configuration (with native_osxstrategy).

➜  docker-sync start
          ok  Starting native_osx for sync monolith-sync
monolith-sync
unison: stopped
unison: ERROR (spawn error)
     success  Sync container started
     success  Starting Docker-Sync in the background

[Deconstrained]

I am convinced I have found the cause of the issue:

The value is expected to default to an empty string (ostensibly) but it's coming through as nil for whatever reason.

PR #698 addresses this by explicitly setting a default.

Edit: there were other issues that came up when I set the default explicitly, so I modified my PR to address the specific exception that arose (i.e. check for whether the value is nil first).

[EugenMayer]

This makes pretty much sense -this was introduced in the last release and we forgot to care about the proper defaults. Thanks for your effort

[Maxooo]

Thank you @Deconstrained for your work and @EugenMayer for the new v0.5.14 version which works perfectly now. Your investment in this project is well appreciated and makes us win so much time with Docker on Mac every-day. 🙏

[EugenMayer]

The main driving force is the community right now, I just take time to coordinate / stuff together. So I forward all the credits to you gents and lads :)