Docker-selenium: dockerish/flexible docker tags

Created on 18 Oct 2016 · 21Comments · Source: SeleniumHQ/docker-selenium

It would be great to support semverish tags eg:

Current

latest -> 3.0.0-dubnium

Proposed

latest -> 2.53.1
2.x.x -> 2.53.1
2.53.x -> 2.53.1
2.52.x -> 2.52.0
beta -> 3.0.0-dubnium
3.0.x -> 3.0.0-dubnium
3.x.x -> 3.0.0-dubnium

Source

graingert

All 21 comments

(using latest automatically upgraded me to the 3.0.0 beta releases, which broke my build)

graingert on 18 Oct 2016

(using latest automatically upgraded me to the 3.0.0 beta releases, which broke my build)

Selenium 3.0 is no longer in beta, and is considered the latest stable version.

davehunt on 18 Oct 2016

Ok here's my v2 proposal:

Current

latest -> 3.0.0-dubnium

Proposed

latest -> 3.0.0
2.x.x -> 2.53.1
2.53.x -> 2.53.1
2.52.x -> 2.52.0
3.0.x -> 3.0.0
3.x.x -> 3.0.0

graingert on 18 Oct 2016

👍1

Looks reasonable to me, though the '-dubnium' indicates docker image updates that do not change the Selenium version in use, so latest would still point to this.

davehunt on 18 Oct 2016

is there an explanation of what -dubnium means anywhere?

graingert on 18 Oct 2016

Ok here's my v3 proposal:

Current

latest -> 3.0.0-dubnium

Proposed

latest -> 3.0.0-dubnium
2.53.1-x -> 2.53.1
2.53.x-x -> 2.53.1
2.52.x-x -> 2.52.0
2.x.x-x -> 2.53.1
3.0.0-x -> 3.0.0-dubnium
3.0.x-x -> 3.0.0-dubnium
3.x.x-x -> 3.0.0-dubnium

graingert on 18 Oct 2016

is there an explanation of what -dubnium means anywhere?

Not sure, but there should be. @ddavison?

davehunt on 18 Oct 2016

I suspect most people will use 3.x.x-x or 2.x.x-x

graingert on 18 Oct 2016

I think the "use -plus- +" comment was removed but just to leave it clear; it doesn't seem to be supported by docker.

Regarding 3.x.x-x or 2.x.x-x maybe is the correct way but so many x (more than 2) reads awkward. I don't have a strong opinion on the subject though.

elgalu on 18 Oct 2016

I removed the plus comment because it's wrong. You're not providing build
metadata it's transitive deps. For semver you need a different strategy

graingert on 18 Oct 2016

Ok here's my v4 proposal:

Current

latest -> 3.0.0-dubnium

Proposed

latest -> 3.0.0-dubnium
2.53.1 -> 2.53.1
2.53 -> 2.53.1
2.52 -> 2.52.0
2 -> 2.53.1
3.0.0 -> 3.0.0-dubnium
3.0 -> 3.0.0-dubnium
3 -> 3.0.0-dubnium

graingert on 18 Oct 2016

👍1

I like v4, looks more like the official docker approach to tags, e.g. https://hub.docker.com/_/python/

elgalu on 18 Oct 2016

it's not semver at all, I'd clone the docker way of doing things

graingert on 18 Oct 2016

is there an explanation of what -dubnium means anywhere?
Not sure, but there should be. @ddavison?

dubnium is a chemical element. I've created a wiki page to explain the tagging convention of this repository.

it's not semver at all, I'd clone the docker way of doing things

The only accurate "semver" part is the Selenium verison. The docker tag represents what version of selenium is going to be pulled. not necessarily the version of this docker image. That's why i use a -<chemical element> suffix to show our version.

I've been bitten in the past updating "recent" tags like this. I definitely like the idea, but force pushing tags back up you run into the problem of breaking something that somebody else expects to work.

ddavison on 18 Oct 2016

I've been bitten in the past updating "recent" tags like this. I definitely like the idea, but force pushing tags back up you run into the problem of breaking something that somebody else expects to work.

which is what latest did to me. I want latest 2 for example

This force pushing stuff is fine, and seems to be what tags are used for (not like git tags, more like branches)

graingert on 18 Oct 2016

the more i think about it, the more i do like it. if it did break for somebody, they could always specify the 3.0.0- version to make it remain unchanged.

3 and 3.0 would be good versions to push to docker tag as latest.. i do like this convention.

ddavison on 18 Oct 2016

👍1

@ddavison is this something that will be applied going forward?

graingert on 15 Nov 2016

@graingert the next release i'll work on it

ddavison on 15 Nov 2016

Woop woop

On 15 Nov 2016 5:56 pm, "Dj" [email protected] wrote:

@graingert https://github.com/graingert the next release i'll work on it

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SeleniumHQ/docker-selenium/issues/312#issuecomment-260716059,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZQTPVkt_gYJkg-NuVmu6fIL9xaQtN4ks5q-fJegaJpZM4KZmDQ
.