Docker-selenium: New docker images 2.53 and 2.52 fail to start

[cehoffman]

The image 2.52 (9f528a33bb6f) and 2.53/latest (727a50d14683) for standalone-chrome-debug fail to start with the following error.

/opt/bin/entry_point.sh: line 4: /opt/bin/functions.sh: No such file or directory
/opt/bin/entry_point.sh: line 17: get_server_num: command not found

[sixinli]

same with the firefox one :(

/opt/bin/entry_point.sh: line 3: /opt/bin/functions.sh: No such file or directory
/opt/bin/entry_point.sh: line 16: get_server_num: command not found

[capoferro]

Looks like an untested commit:
https://github.com/SeleniumHQ/docker-selenium/commit/1b2786e6090dbda785d5869db2ef73c3f20ad923

It refactors the entrypoint.sh, but doesn't update the Dockerfile or provide the functions.sh that the new entrypoint.sh needs.

[capoferro]

@kayabendroth ^

[joemewes]

Tested and confirmed only seems to be an issue with the -debug drivers. non-debug driver for both chrome and firefox work fine.

[pda]

Tested and confirmed only seems to be an issue with the -debug drivers. non-debug driver for both chrome and firefox work fine.

The source code of the non-debug standalone-chrome also has an entry_point.sh (actually used as CMD not ENTRYPOINT) sourcing non-existent /opt/bin/functions.sh. However that code doesn't seem to have landed in the recent 2.52.0 or 2.53.0 image tags, but is broken in the :latest tag:

pda@paulbook ~ ❯ docker run --rm -it selenium/standalone-chrome:latest
/opt/bin/entry_point.sh: line 3: /opt/bin/functions.sh: No such file or directory
/opt/bin/entry_point.sh: line 16: get_server_num: command not found

[capoferro]

An easy way to demonstrate the problem:

$ docker run selenium/standalone-chrome:latest ls /opt/bin
entry_point.sh
$ docker run selenium/standalone-chrome:latest cat /opt/bin/entry_point.sh
#!/bin/bash

source /opt/bin/functions.sh

# ...etc

[joemewes]

Is this the file thats missing from the build && branch : https://github.com/SeleniumHQ/docker-selenium/blob/master/NodeBase/functions.sh

So the Codebase containers branches master, 2.52.0 and 2.53.0 need this added and the functions.sh file so this function can be used in the debug containers?

[edit]

COPY \
  entry_point.sh \
  functions.sh \
    /opt/bin/
RUN chmod +x /opt/bin/entry_point.sh

to replace in the nodeFirefoxDebug Dockerfile I would think : https://github.com/SeleniumHQ/docker-selenium/blob/2.53.0/NodeFirefoxDebug/Dockerfile#L52

Can anyone create PRs for this repo? Am new to contributing.....

[armandabric]

I confirm I have an issue the node-chrome one:

$ dc up selenium_node_chrome
myproject_selenium_hub_1 is up-to-date
Starting myproject_selenium_node_chrome_1
Attaching to myproject_selenium_node_chrome_1
selenium_node_chrome_1                 | xvfb-run: error: Xvfb failed to start
myproject_selenium_node_chrome_1 exited with code 1

[andrerom]

selenium/standalone-firefox:latest broken here as well..

But I do seem to have the same issue with 2.53.0 which has same size _(240mb)_ as latest, unlike 2.52.0 which is 312mb and seems to work.

[kayabendroth]

I checked the 2.53.0 tagged images and did not get the error. But can reproduce with latest

[kayabendroth]

Please check, if this is fixed for you with the images from today.

Latest changes from master have been merged into 2.53.0 branch, thus triggering a rebuild of 2.53.0 and latest images.

[joemewes]

@kayabendroth is it not the debug versions doing this : https://github.com/SeleniumHQ/docker-selenium/blob/master/NodeFirefoxDebug/entry_point.sh#L3

&& the Dockerfile missing the COPY command to bring in the functions.sh file : https://github.com/SeleniumHQ/docker-selenium/blob/master/NodeFirefoxDebug/Dockerfile#L52

as the NodeBase Dockerfile currently does : https://github.com/SeleniumHQ/docker-selenium/blob/master/NodeBase/Dockerfile#L28

?

[kayabendroth]

@4alldigital The _node*debug_ images are build off of their _node_ counterparts, which are based on _node-base_. And _node-base_ already has /opt/bin/functions.sh. Have a look at https://hub.docker.com/r/selenium/node-firefox-debug/builds/bauzaguyjczuwpkscy3yarb/.

[joemewes]

yeah, I was wondering if thats how it was supposed to work.. but looked like it didn't need fixing if that were the case. I'll pull and build from latest and let you know how I get on.

Thanks for the fixes.

[joemewes]

@kayabendroth confirmed pulled and working locally here with :latest *-debug containers. nice work!
thanks

[park9140]

@kayabendroth, I seem to still have this problem with the debug builds even using 2.53.0 I am on docker version 1.9.1 is there a dependency or something that needs to be cleared out if you had it before this fix?

[vikramvi]

I got this working with command

docker run -d -P -e no_proxy=localhost -e HUB_ENV_no_proxy=localhost --link selenium-hub:hub selenium/node-chrome-debug