Docker-gitlab: Gitlab Clone button not showing port and protocol after update to 12.10.4

[jarosjir]

After upgrading from 12.9.5 to 12.10.4, the Clone button in the GUI stop showing the protocol and port. The configuration was not changed
Now it shows
[email protected]:group/project.git
instead of
ssh://[email protected]:9418/group/project.git

[johnmccabe]

Also seeing this with todays 12.10.6, can't figure out whats caused the change yet.

My GITLAB_SSH_PORT is still set as expected, and the port is bound ok, if I manually correct the clone URL its still working.

[johnmccabe]

I've tried setting GITLAB_SSH_LISTEN_PORT as well which I hadn't set. The old GITLAB_SSH_PORT defaults to the setting in that new variable.

https://github.com/sameersbn/docker-gitlab/compare/12.9.5...12.10.6

But that doesn't seem to have any effect either. Bit surprised to see that the old var is set to default to the new one, would perhaps have been easier for backwards compatibility to have the new default to old.. but at this point seems unrelated.

[fgracia]

Hello,

Same problem here, it seems that the variable GITLAB_SSH_PORT is not set in the config/gitlab.yml file.

Previously we could find this line :

ssh_port: **custom_port**

Now this line does not appear anymore.

[solidnerd]

Hey at all,
I tested the current configuration here is the final rendered output:
https://gist.github.com/solidnerd/ae0ab7b0a7b4e44c6d5fcdf964cf4372
It seems that the related configuration is missing in the substituted config.

[solidnerd]

Could be related with this line https://github.com/sameersbn/docker-gitlab/blob/master/assets/runtime/functions#L871 . I think we need to switch the search entry point in the sed command to different value. Because upload comes now multiple times in the document.

[solidnerd]

I'll try to provide a fix for tomorrow during the day. Otherwise feel free to do a pull request I would really appreciate it.

[Kimmyzhao]

[vitosans]

Whats the fix? I upgraded this morning and am now suffering from the same issue.

[solidnerd]

@vitosans Read my comment from https://github.com/sameersbn/docker-gitlab/issues/2147#issuecomment-630364938 . I think this comes from sync the upstream configs and a new upload: key was introduced in https://github.com/sameersbn/docker-gitlab/blob/master/assets/runtime/config/gitlabhq/gitlab.yml#L1087 . During the sed command will catch the upload: key and delete all lines below the gitlab.yml . This is why the gitlab shell config is missing.

[vitosans]

@solidnerd - I can confirm that upload: is what is causing the issue. However, once I get a proper config I am still prompted for a password its not using the authorized_keys file:

Cloning into 'my_project'...
git@xxxxx's password:

Any ideas?

• UPDATE -

Found my issue, it had to do with the GITLAB_SSH_LISTEN_PORT and the old GITLAB_SSH_PORT - will wait for the proper fix for the sed issue, as mine is hacky

[solidnerd]

Hey at all,
@coolersport provided a fix for your issue. Thanks for this again. I think we are not back in settled water. It will be appear in 12.10.6-1 afterwards this is released (Release Is currently in progress). I will gonna close this issue because it's not reproducible than anymore. Otherwise feel free to reopen this issue if it still exists.

[johnmccabe]

Thanks @solidnerd and @coolersport - just updated to 12.10.6-1 and ports are being rendered in clone URLs again.