Dnn.platform: Deprecate DisplayCopyright Host Setting

[mikesmeltzer]

Description of problem

The DisplayCopyright host setting is now no longer in active use for it's intended purpose. However, the deprecated RibbonBar project and an older skin object still reference the setting.

Description of solution

Deprecate the property (and skin object) to be removed in v11.

Additional Context

This is a follow-up to PR #3524 .

The skin object in question, for reference, is "/Admin/Skins/DotNetNuke.ascx". This is used to display the DNN product copyright in a Skin, is not referenced or used within platform anymore.

[sleupold]

wouldn't it make sense to keep it for the Copyright skin object to display site copyright term within the Theme applied to the site?

[mikesmeltzer]

I don't think so. This skin object is used for displaying the DNN product copyright and not used within the platform or core skin. Not to be confused with something that shows your particular website copyright, that's a different skin object.

The skin object in question, for reference, is "/Admin/Skins/DotNetNuke.ascx".

[stale[bot]]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[EPTamminga]

Still valid

[stale[bot]]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[mikesmeltzer]

Still valid, keep open.

[valadas]

I thought this was done already, did you double-check @mikesmeltzer

[mikesmeltzer]

Yes, the file still exists.

[sleupold]

would deleting the skin object not break existing 3rd party skins containing it?
In this case, it could only be removed aver next but one major version after it being marked as deprecated.

[valadas]

would deleting the skin object not break existing 3rd party skins containing it.

Yes it would, we need to deprecate the property for removal in v11. (If a PR comes in to deprecate this in v9).

[mikesmeltzer]

@valadas how do we deprecate a skin object since it's an ascx control? Just mark it as such on its corresponding code behind file?

[valadas]

Yeah, as skin developers don't really compile, they won't get much of a warning about it, it's not perfect for sure.... But we can at least mention it in release notes...

[mikesmeltzer]

Makes sense. I'll make a PR for it to mark it as deprecated in v11 on the C# side and submit that in a bit.

This is minimal risk; I think few would embed the actual DNN Copyright into their skin.