Dnn.platform: Misspelled Class - in UserControls / PersonaBarContainer.ascx

[jeremy-farrance]

Description of bug

Someone else noticed an odd typo/misspelling and hopefully it is a simple fix. Maybe not?

See the image below, See the extra L on 'persona-Bar' ? Someone accidentally typed 'personal'

Screenshots

Here is a direct link to the file

Additional context

Note that Daniel Valadas took a brief look at it and seemed to quickly determine that this IS a breaking change. Hopefully he will comment?

Affected version

• [x] 9.4.2 alpha build
• [x] 9.4.1 latest supported release

Affected browser

• browser is not relevant

[thabaum]

sounds like a personal issue to me :) sorry could not resist...

[valadas]

As much as it is a type and should be corrected, it could be a breaking change for third parties relying on that wrong spelling. In my opinion we could add the correct spelling on top of keeping the wrong one pretty much any time and then remove the wrong spelling after at least one full version. Like add the correct one now and remove the wrong one in Dnn10... Thoughts?

[bdukes]

Yes, let's add the corrected class now, and later remove the typo class

[thabaum]

We are discussing new naming class convention... could this wait? Maybe it can follow the new community guidelines if we can agree on one.

[valadas]

Well, I am not picky on class names, but yeah if there is some sort of standard agreed upon I don't mind, this is just a typo so nothing rush.

[thabaum]

I think stick to the way the page is putting the correct one first... might look funny for a while... say 3-4versions probably before someone removes it potentially :) I might put it in my module so it has to stay a while hehe, or be that guy that complains when it breaks..

I would like at least to see a Coding Standards for any files made in the future that can be held to it.

[thabaum]

Do you think putting a comment above it to use the new class in the file as well to help avoid someone thinking they can use it?

[valadas]

I think we just need to document this as a breaking change in the release notes of the first version that introduces the new class name and the first version that removes the old class name... Module developers should follow the release notes of the platform they are building their solutions on... Honestly I think there might only be a handful of modules affected by this change, but just to err on the safe side.