Dnn.platform: Client Dependency Reference is BLOCKING any local development

[ahoefling]

The ClientDependency.Core reference in the DNN_Platform.sln is breaking and blocking any local development on the platform. This was originally setup as a git submodule but has been causing lots of issues for several developers.

I have been speaking with the team in DNN TAG and we have a proposed solution:

• Add a nuget on the DNN MyGet for the Client Dependency project https://github.com/dnnsoftware/ClientDependency
• Update the platform code to reference via NuGet

[ahoefling]

I created a fork that is compiling right now with the ClientDependency.Core submodule removed. Once we get the forked repo building and producing a nuget file I will update the branch I have and submit a Pull Request

[tpluscode]

@ahoefling we talked AppVeyor. would you be interested in setting up a build/packaging/publish for the ClientDependnecy fork?

[ahoefling]

@tpluscode Yes, I just need to be given access to the DNN Company on github and access to that repository so I can create the necessary builds in AppVeyor.

This isn't really a complicated setup process at all, it is just a matter of getting access and then I can setup the builds and submit a PR

[bdukes]

What I usually do when setting up AppVeyor on someone else's repo is to set it up for my fork, and then create a PR for the final appveyor.yml file, which they can then merge in. The turning on AppVeyor on their end is just clicking one button.

I think it would be good for a handful of folks from the DNN TAG to have more access in the _dnnsoftware_ organization on GitHub, but I also don't want to wait for that to get decided and acted upon before this can get moving.

[tpluscode]

It's enough for me to add ClientDependency to Appveyor and set it up for running pull requests which is pretty much the default behaviour. I will do it as soon as @ashishpd adds the admin team to the repo. Currently it doesn't show up on AppVeyor for me. When it's done you will be able to submit a PR with the appveyor.yml definition, @ahoefling.

Once it builds fine I will merge and set up environment deployment to NuGet/MyGet.

I think it would be good for a handful of folks from the DNN TAG to have more access in the dnnsoftware organization on GitHub

I do agree, @bdukes. As per the above, this itself is not a blocker to proceed with the issue at hand though. Let's discuss adding more people to GH at the TAG meeting?

[ahoefling]

@tpluscode I just created a Pull Request for the dnnsoftware fork of ClientDependency and I linked all the commits/PRs back to this parent issue. There were some issues with the default build script in our dnn fork so I commented out stuff that we are not using in the Dnn Platform.

I don't know if we got a clear direction in our NuGet feeds so the build currently produces the .nukpg and it should be dropping those packages into the appveyor project feed at https://ci.appveyor.com/nuget/clientdependency-dnn

Once we get this changed merged into the dnnsoftware fork we can address how we want to deliver this to the platform project, we have lots of options.

[ahoefling]

This issue should NOT be closed until we have a pull request merged into Dnn platform that resolves the local development scenario. I just opened a new linked issue in the CD project regarding the MyGet server

dnnsoftware/ClientDependency#6

[ahoefling]

@tpluscode once we finish reviewing #2065 and merge that PR we can close this issue

[tpluscode]

Ofc. It was closed via your commit, mind you ;)

[chrisvesco]

Why is this closed? I can't build DNN Platform because Dnn.ClientDependency can't be found..

[mitchelsellers]

@chrisvesco This was closed due to the merged PR back in May of 2018. Be sure to get the latest, as a local compile is successful.

[chrisvesco]

I downloaded the source from https://www.dnnsoftware.com/community/download just now, unzip it try to build, and I get the Dnn.ClientDependency is missing.

FYI I went to your site and wanted to check out the DotNetNuke performance presentation and the link is broken.

[mitchelsellers]

We don’t have easy control on those links. If you can download the source from the Releases tab here on GitHub that should work.

Thanks on the other link ill address tomorrow

[chrisvesco]

Yep thanks Mitchell if I get the 9.3.2 release from GitHub it works fine. I'm also starting to understand how MVC fits into DNN by checking out the code

[chrisvesco]

Off topic: Say Mitchel where do I get your Module Professional Development book?

[mitchelsellers]

Looks like it is still available on Amazon. Sadly though it is a bit out of date at this point as MVC etc wasn’t around yet.

Professional DotNetNuke Module Programming https://www.amazon.com/dp/0470171162/ref=cm_sw_r_cp_api_i_O1FhDbDE7D42R