Django-tables2: There is no CSS class for footers

[mpasternak]

Hi,

while trying to use CSS to style columns to right-align text, I noticed, that the columns in the footer do not have proper class attribute.

Do you think this is a bug and do we want to add class attribute to footers too?

If "yes", I think I can come up with a solution.

[jieter]

I think yes, yes.
Maybe you can tackle #497 while doing that too?

[mpasternak]

Sounds reasonable, give me a few days then.
—
📱[phone] 📧 michal.[email protected]

Wiadomość napisana przez Jan Pieter Waagmeester [e-mail] w dniu 16.11.2017, o godz. 10:26:

I think yes, yes.
Maybe you can tackle #497 https://github.com/jieter/django-tables2/issues/497 while doing that too?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/jieter/django-tables2/issues/499#issuecomment-344864693, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkhxaGlp33lQRH6dfiuvpn-u6XoLTwmks5s2__TgaJpZM4QeNB3.

[mpasternak]

Hi,

I'm working on my issue, eg. this issue, #499.

I think that we need to do work in phases, first phase is to fix #499.

THEN I'll take care of the not-exactly-optimal CSS class names for columns, because I think those need to be well described in the docs. Also I'm thinking of leaving the current behaviour because of backwards compatibility. If someone depends on the class names and the column has a label like "Pkt. MNiSW" (like in my project, http://github.com/mpasternak/django-bpp), then chances are somebody depends on selectors like $(".Pkt\..MNiSW") or CSS like TD.Pkt..MNiSW (I'm not even sure this last one would work).

Then, we leave this for a few versions, spewing out a DeprecationWarning anytime django_tables2 encounters name with dots in it (like "Looks like you may depend on CSS classes named with dots, in the future release dots will be replaced with dashes").

That's how I see that. Django-tables2 package may be widely used so I guess people may depend on that.

So, as for now, I'm working on this issue and I'll submit a pull-request, perhaps with some patches for the docs. Next thing for me will be #497 as no doubt this needs fixing too. Regards,

[jieter]

you are right, we should use a sensible upgrade path and not suddenly break things, looking forward to your PR(s), help is really appreciated!

[isolationism]

:+1: on this. Is there any workaround to pass class or attributes to the table footers in the meanwhile?

[jieter]

I'll merge and release #499 on monday

[mpasternak]

@isolationism I have found none, this is why I came up with this PR. It basically involves messing with the template and with the code. So I basically um like did both here

@jieter HOORJ & thanks for your helpful comments, I appreciate the time you took to review my code!

[jieter]

released 1.16.0

[mpasternak]

👍 good job and thanks for the review