Django-rest-framework: All Python 3 builds failing on Travis.

Created on 28 Mar 2019 · 7Comments · Source: encode/django-rest-framework

  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/tox_venv/hooks.py", line 99, in tox_testenv_create
    venv.session.make_emptydir(venv.path)
AttributeError: 'VirtualEnv' object has no attribute 'session'

<poem>Sigh. CI.</poem>

Bug

Source

carltongibson

Most helpful comment

Quick fix FTW

tomchristie on 28 Mar 2019

😄2

All 7 comments

A new version of tox-venv presumably?
We could pin tox and tox-venv in the travis file.

tomchristie on 28 Mar 2019

I'm currently working on an update to tox-venv. The quick fix is to pin tox==3.7.0.

rpkilby on 28 Mar 2019

Sounds legit.

tomchristie on 28 Mar 2019

Quick fix FTW

tomchristie on 28 Mar 2019

😄2

Latest build passed... (will have a look later.)

carltongibson on 29 Mar 2019

Closing as this should be fixed now. Released tox-venv v0.4.0

rpkilby on 2 Apr 2019

btw, we could actually just remove the tox-venv dependency. There isn't any benefit in using it here, since we don't have a warnings build (a la django-filter).

rpkilby on 4 Apr 2019

Was this page helpful?

0 / 5 - 0 ratings