Django-rest-framework: Missing file in the 3.7.4 release.
static/rest_framework/fonts/glyphicons-halflings-regular.woff2 is missing from the 3.7.4 tarball while being in the repository.
Unfortunately this break some static files pipelines since the file is referenced in some css.
xordoquy
All 9 comments
https://github.com/encode/django-rest-framework/blob/a81e60ff390b9b6788b2cac24a01ee4dd2dcffd2/MANIFEST.in#L3 this line seems to be the problem.
Why is it not simply * instead of listing all the extensions?
axnsan12
on 20 Dec 2017
Probably because at some point there was other -intermediate- files in there.
xordoquy
on 21 Dec 2017
And would it be ok to change it to * now? I think that would be safer in the future to prevent things like this from happening again.
axnsan12
on 21 Dec 2017
Looks like #5695 is related. Maxim: Never touch the packaging. (Grrrr. 馃檪)
We have the dist build now:
We should be able to add smoke tests at least (i.e. they don't need to be perfect) to catch these kind of regressions.
(Grrrr. 馃檪)
carltongibson
on 21 Dec 2017
And would it be ok to change it to * now? I think that would be safer in the future to prevent things like this from happening again.
That's a double edged sword. It could also include unwanted temporary files.
xordoquy
on 21 Dec 2017
That's a double edged sword. It could also include unwanted temporary files.
Which would IMO be better than missing important files because it's unlikely to break stuff. recursive-excludeor global-exclude would also be able to fix that just as well as including by extension.
One could also argue that temporary/intermediate files should sit in separate directories in the first place.
axnsan12
on 21 Dec 2017
One could also argue that temporary/intermediate files should sit in separate directories in the first place.
I totally agree with that by sometime, when it's generated, it's not as easy. I remember packaging my own pyc files once.
We need to weight all that and take a decision.
xordoquy
on 21 Dec 2017
Keep it simple: We add *.woff2 and roll a new release.
tomchristie
on 21 Dec 2017
3.7.5 released
tomchristie
on 21 Dec 2017
Related issues
jpocentek
路
3Comments
hemanthsp
路
3Comments
sebdiem
路
3Comments
doctorallen
路
3Comments
tomchristie
路
3Comments
Most helpful comment
3.7.5 released