Django-jet: utils.py -> get_model_queryset() missing 1 required positional argument: 'sortable_by'
This is an incompatible error when you install django-jet==1.0.7 with Django==2.1
Traceback:
Environment:
Request Method: GET
Request URL: http://localhost:8000/admin/xxx/user/1/change/Django Version: 2.1
Python Version: 3.6.5
Installed Applications:
['jet.dashboard',
'jet',
'django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.messages',
'django.contrib.staticfiles',
'rest_framework',
'storages',
'mobijuce_general',
'mobijuce_util',
'mobijuce',
'mobijuce_admin',
'mobijuce_jwt',
'mobi_apis',
'rest_framework_swagger']
Installed Middleware:
['django.middleware.security.SecurityMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware',
'django.middleware.locale.LocaleMiddleware']Template error:
{% endblock %}
In template /home/dang/Projects/python/mjapi/lib/python3.6/site-packages/jet/templates/admin/base.html, error at line 122
__init__() missing 1 required positional argument: 'sortable_by'
112 :
113 : {% block footer %}
114 :
115 : {% jet_delete_confirmation_context as delete_confirmation_context %}
116 : {{ delete_confirmation_context }}
117 :
118 : {% jet_change_form_sibling_links_enabled as show_siblings %}
119 : {% if change and show_siblings %}
120 :
socrec
All 8 comments
To fix this error, change jet/utils.py line 220 to 223 like this
cl = ChangeList(request, model, list_display, list_display_links, list_filter, model_admin.date_hierarchy, search_fields, list_select_related, model_admin.list_per_page, model_admin.list_max_show_all, model_admin.list_editable, model_admin, model_admin.sortable_by)
Because from 2.1, Django ChangeList require sortable_by parameter. For more information check https://github.com/django/django/blob/master/django/contrib/admin/views/main.py line 39
socrec
on 2 Aug 2018
Please apply better fix in #345
socrec
on 12 Aug 2018
@socrec How can I override jet/utils.py file to add what you say, I must change?
Thank you.
alfredrumss
on 16 Aug 2018
@alfredrumss
I'm not sure if this is a recommended method or best practice, since I'm new to django (my background is PHP), but this is what I did while we have to wait for geex-arts to update the bug fix.
Basically, jet is just an app like every other apps that we create, so, I simply just copy it to the the same level with other apps like in the image above. And it just works. Until further updates, I'll just remove or rename that folder just to be sure. And it will load the default jet in lib.
But I recommend you to follow the fix in #345
socrec
on 16 Aug 2018
How is this still broken?
RoninDusette
on 7 Dec 2018
@RoninDusette it was fixed and merged into dev, they just haven't released a new version yet.
Kindly check #345 for more information :)
socrec
on 7 Dec 2018
When this fix omg... I changed model_admin.sortable_by on line 223 still same bug . ffs
logicappsource
on 5 Jan 2019
@logicappsource the fix at #345 has been merged to geex-arts:dev, you can try to pull from that instead.
Or if you don't want to use dev because of stability concern, you can try this
@alfredrumss
I'm not sure if this is a recommended method or best practice, since I'm new to django (my background is PHP), but this is what I did while we have to wait for geex-arts to update the bug fix.
Basically, jet is just an app like every other apps that we create, so, I simply just copy it to the the same level with other apps like in the image above. And it just works. Until further updates, I'll just remove or rename that folder just to be sure. And it will load the default jet in lib.
But I recommend you to follow the fix in #345
socrec
on 5 Jan 2019
Related issues
pwndr00t
路
4Comments
RamizSami
路
4Comments
leogout
路
8Comments
erayerdin
路
5Comments
uroybd
路
5Comments
Most helpful comment
To fix this error, change
jet/utils.pyline220to223like thiscl = ChangeList(request, model, list_display, list_display_links, list_filter, model_admin.date_hierarchy, search_fields, list_select_related, model_admin.list_per_page, model_admin.list_max_show_all, model_admin.list_editable, model_admin, model_admin.sortable_by)Because from 2.1, Django
ChangeListrequiresortable_byparameter. For more information check https://github.com/django/django/blob/master/django/contrib/admin/views/main.py line39