Distributed: Rotate text of Bandwidth type chart

[mrocklin]

We should probably slightly rotate the labels on the x axis so that they pack a bit more nicely.

This requires understanding a bit of Bokeh (or looking at their docs) and modifying the BandwidthTypes class here

https://github.com/dask/distributed/blob/907452b1bc0f7876a01de5ff39cc2dc64eb3c4a4/distributed/dashboard/components/scheduler.py#L274-L322

[mrocklin]

We do this for other plots too, so there are probably examples of rotating text in that same file

[quasiben]

fig.xaxis.major_label_orientation = -math.pi / 12 is what we've typically done

[hugobowne]

I'll happily take a stab at this, probably next week some time!

[mathdugre]

@hugobowne Did you start working on this issue ? Otherwise, I would be glad to work on it.

[mrocklin]

Go for it Mathieu

On Sat, Aug 8, 2020, 4:20 PM Mathieu Dugré [e-mail] wrote:

@hugobowne https://github.com/hugobowne Did you start working on this
issue ? Otherwise, I would be glad to work on it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/distributed/issues/3992#issuecomment-670984185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTAATZQYLFE75LHCJE3R7XMT3ANCNFSM4PJRXKGQ
.

[mathdugre]

Following @quasiben suggestion I set the fig.xaxis.major_label_orientation to rotate the x-axis labels. After trying different values, I found that a rotation of -0.5 looked pretty good.
Those are the plots generated with a value of -0.5:

Dask Bandwidth [Type]

Dask Bandwidth [Type] (smaller window)

If this seems good, I'll open a PR.

[mrocklin]

It seems like an improvement to me :)

On Sat, Aug 8, 2020 at 9:41 PM Mathieu Dugré [e-mail]
wrote:

Following @quasiben https://github.com/quasiben suggestion I set the
fig.xaxis.major_label_orientation to rotate the x-axis labels. After
trying different values, I found that a rotation of -0.5 looked pretty
good.
Those are the plots generated with a value of -0.5:
Dask Bandwidth [Type]

[image: image]
https://user-images.githubusercontent.com/16450132/89724992-c8f7f980-d9f9-11ea-9655-584b094bcb03.png
Dask Bandwidth [Type] (smaller window)

[image: image]
https://user-images.githubusercontent.com/16450132/89724994-d0b79e00-d9f9-11ea-9f9c-ce774dd944a2.png

If this seems good, I'll open a PR.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/distributed/issues/3992#issuecomment-671005574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTC3IKPNIEC5H7CZRODR7YSIHANCNFSM4PJRXKGQ
.

[hugobowne]

This looks cool. Apologies for dropping the ball slightly here.