Discord.py: PEP 614

[j0hnmeow]

The Problem

Checking if at least one of checks passes

The Ideal Solution

PEP 614 (implemented in Python 3.9) relaxes decorator syntax, allowing writing things like

@check1 | check2
async def cmd(ctx):
    pass

The Current Solution

@check_any(check1, check2)
async def cmd(ctx):
    pass

Summary

Implement __or__ for all callables returned from check

[Rapptz]

This is not good. Also the PEP 614 just relaxes grammar and 3.9 is not the minimum version for the library.

[j0hnmeow]

3.9 is not the minimum version for the library.

But that won't break code on lower versions

[j0hnmeow]

And why is it not good?

[korochun]

Agreed. Implementing __or__ won't hurt Python 3.8- users, but definitely would benefit 3.9+ users.

[BluePhoenixGame]

Agreed. Implementing __or__ won't hurt Python 3.8- users, but definitely would benefit 3.9+ users.

It needs to not hurt Python 3.5.3 users which is the lowest requirement for discord.py

[j0hnmeow]

Agreed. Implementing __or__ won't hurt Python 3.8- users, but definitely would benefit 3.9+ users.

It needs to not hurt Python 3.5.3 users which is the lowest requirement for discord.py

I don't see how can it hurt them. Also Python 3.5 itself is not supported.

[Gobot1234]

I personally do not agree with this change, the proposed syntax is no better than the current option.

[j0hnmeow]

A lot of people will find it more intuitive

[numbermaniac]

It needs to not hurt Python 3.5.3 users which is the lowest requirement for discord.py

I don't see how can it hurt them. Also Python 3.5 itself is not supported.

At https://github.com/Rapptz/discord.py#installing it says that 3.5.3 or higher is supported, so your statement isn't true at all.

[j0hnmeow]

It needs to not hurt Python 3.5.3 users which is the lowest requirement for discord.py

I don't see how can it hurt them. Also Python 3.5 itself is not supported.

At https://github.com/Rapptz/discord.py#installing it says that 3.5.3 or higher is supported, so your statement isn't true at all.

Which of them?

1. I tried using a library with a fix on Python 3.5, it did work
2. Python 3.5 reached end of life on 30/09/2020

[iomintz]

Danny has stated on multiple occasions that he doesn't care about official EOL dates and will continue to support older versions until it becomes infeasible to do so.

[j0hnmeow]

Danny has stated on multiple occasions that he doesn't care about official EOL dates and will continue to support older versions until it becomes infeasible to do so.

3.5 still won't break

[SebbyLaw]

The fact that it doesn't break previous versions is irrelevant if the library maintainer doesn't want the syntax to be used.

The fact that this issue is closed should speak volumes. Feel free to fork the library and implement whatever syntax support you desire, after all, it is open source.