Discord.py: V1.2.5 throws KeyError when API is misbehaving, 1.3.1 shares the same code

[ghost]

At the time of writing, the API is having latency issues. Responses are still coming back, but content-type headers are missing which is causing a key error to raise rather than an internal server error.

I am aware I am using an outdated library version, but inspecting the source for 1.3.1, no mitigation has been made for this issue, so this will impact 1.3.1 as well.

No clue what the body is causing it, but it is being triggered by editing messages:

Traceback (most recent call last):
  File "/neko3/.venv/lib/python3.8/site-packages/discord/ext/commands/core.py", line 79, in wrapped
    ret = await coro(*args, **kwargs)
  File "/neko3/neko3/features/ping_pong.py", line 124, in ping_command
    await msg.edit(content="", embed=embed)
  File "/neko3/.venv/lib/python3.8/site-packages/discord/message.py", line 744, in edit
    data = await self._state.http.edit_message(self.channel.id, self.id, **fields)
  File "/neko3/.venv/lib/python3.8/site-packages/discord/http.py", line 162, in request
    data = await json_or_text(r)
  File "/neko3/.venv/lib/python3.8/site-packages/discord/http.py", line 43, in json_or_text
    if response.headers['content-type'] == 'application/json':
KeyError: 'content-type'

Corresponds to L164 on 4cf5f792d402fe8f6fea054c87da7f460a594aa0 in http.py

This has occurred three times within 10 minutes. Probably worth putting something in to check for this in the future and provide a meaningful exception instead to be safe.

[Rapptz]

Cloudflare responses seem to no longer specify that it's HTML text via content type like it used to. Considering this has never come up in 4 years it must be a recent change on their end.

[skyblockz]

dis.gd/status
Other than that 50k ping is api misbehavior
For me discord is sending g empty websocket, it should be back soon

[anurag-7]

It might be due to the key value not being cased correctly.

[NotSoSuper]

Had this issue yesterday, a few thousand errors..

[ghost]

It might be due to the key value not being cased correctly.

I can't speak for aiohttp, but most sane HTTP implementations tend to use a tree map for HTTP headers with a case insensitive comparator. I know there is no treeset primitive in python, but aiohttp.typedefs.LooseHeaders should provide this functionality I would hope, so case sensitivity in HTTP headers should be ignored

[Dimbreath]

I can confirm this happens (and quite a lot recently) on 1.3.0.

[Moooog]

happend to me earlier and some other people.

[Moooog]

Command raised an exception: KeyError: 'content-type'