Discord.js: breaking: discord.js types are broken after newest changes

Created on 13 Jan 2020  ·  4Comments  ·  Source: discordjs/discord.js

Please describe the problem you are having in as much detail as possible:
Our CI threw this right after #3530 was merged into master
This failed us both on new staging as well as old, long-tested production builds that installed the new version on build
image

Include a reproducible code sample here, if possible:
install discord.js
use typescript
try to compile

Further details:

  • discord.js version: current as of the commit mentioned
  • Node.js version: 10.x
  • Priority this issue should have – please be realistic and elaborate if possible: high
  • [x] I have also tested the issue on latest master, commit hash: 8014ddcd1c651749fc64e8dfc0b0863422d57203
unverified bug

All 4 comments

Fixed in #3689

You should definitely add TS compilation to the CI tests, then this type of error can never happen from merging into master.

Should also probably not rely on master for production 👀
But yes, generally this will be done.

The production part was tested and mentioned to make sure that no changes on our codebase could have been the cause 😁

Nice 👍

Was this page helpful?
0 / 5 - 0 ratings