Discord.js: Promise from `Guild.createRole` does not fail when maximum role limit is reached.

[GrantGryczan]

Please describe the problem you are having in as much detail as possible:

In that image, I've placed two red marks next to some code. In most cases, only the first marked line would run. In a case where Discord's maximum role limit is reached, you'd expect that the second marked line would run after the promise fails. Instead, when the maximum role limit is reached and Guild.createRole is called, neither line runs and nothing happens. The promise doesn't fail and no error or warning is displayed in the console.

Further details:

• discord.js version: 11.1.0
• node.js version: 7.8.0
• Operating system: Ubuntu 16.04.3 LTS
• Priority this issue should have – please be realistic and elaborate if possible:
  This issue does not need high priority, as I can just tell members myself that we've hit the role limit instead of having the bot do it automatically.

• [ ] I found this issue while running code on a __user account__
• [ ] I have also tested the issue on latest master, commit hash:

[ShayBox]

Same with createChannel

[devsnek]

@ShayBox @Miroware8 please confirm the master hashes you tested this bug with

[GrantGryczan]

@devsnek How?

[CyberiumShadow]

@Miroware8 check your package-lock.json

[GrantGryczan]

@CyberiumShadow What am I looking for?

[CyberiumShadow]

@Miroware8 A line that looks like this

[devsnek]

or like npm ls discord.js

[robflop]

I've confirmed that both errors are emitted on commit hash c4df2502 of master.

Channel limit: http://i.imgur.com/WIhLjtu.png

Role limit: http://i.imgur.com/dLpr9gz.png

[GrantGryczan]

@CyberiumShadow I don't have a line like that. All three occurrences of "discord.js" are in this screenshot.

[robflop]

@Miroware8 Gus was asking about the master branch commit you tested this on -- but seeing as you're on version 11.1, I assume you didn't test it on master.

Also see my comment above, the issue is fixed on the master branch.

[iCrawl]

^